All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Falcon <sethfalcon@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: gitk broken or user error?
Date: Mon, 13 Nov 2006 14:38:57 -0800	[thread overview]
Message-ID: <m2y7qfezum.fsf@ziti.local> (raw)
In-Reply-To: <m27ixzgex4.fsf@ziti.local> (Seth Falcon's message of "Mon, 13 Nov 2006 14:28:07 -0800")

Seth Falcon <sethfalcon@gmail.com> writes:
> I tried this patch:

And then I used grep :-)

This patch seems to get the view menu items working.  The only strange
thing I see now is that if I create a new view and then try to delete
it, it stays around in the menu.

+ seth

diff --git a/gitk b/gitk
index ab383b3..d9df0a3 100755
--- a/gitk
+++ b/gitk
@@ -1632,8 +1632,8 @@ proc showview {n} {
 
     set curview $n
     set selectedview $n
-    .bar.view entryconf 2 -state [expr {$n == 0? "disabled": "normal"}]
-    .bar.view entryconf 3 -state [expr {$n == 0? "disabled": "normal"}]
+    .bar.view entryconf "Edit*" -state [expr {$n == 0? "disabled": "normal"}]
+    .bar.view entryconf "Delete*" -state [expr {$n == 0? "disabled": "normal"}]
 
     if {![info exists viewdata($n)]} {
        set pending_select $selid
@@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs
     set viewargs(1) $revtreeargs
     set viewperm(1) 0
     addviewmenu 1
-    .bar.view entryconf 2 -state normal
-    .bar.view entryconf 3 -state normal
+    .bar.view entryconf "Edit*" -state normal
+    .bar.view entryconf "Delete*" -state normal
 }
 

  reply	other threads:[~2006-11-13 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-12 17:00 gitk broken or user error? Seth Falcon
2006-11-13  5:20 ` Shawn Pearce
2006-11-13 22:05 ` Paul Mackerras
2006-11-13 22:28   ` Seth Falcon
2006-11-13 22:38     ` Seth Falcon [this message]
2006-11-13 22:42     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y7qfezum.fsf@ziti.local \
    --to=sethfalcon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.