From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Creekmore Subject: Re: [PATCH v5 5/5] sched: Use the auto-generated list of schedulers Date: Thu, 14 Jan 2016 10:25:18 -0600 Message-ID: References: <1452782954-56016-1-git-send-email-jonathan.creekmore@gmail.com> <1452782954-56016-6-git-send-email-jonathan.creekmore@gmail.com> <5697D80D02000078000C6DE9@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aJki9-0000K0-WF for xen-devel@lists.xenproject.org; Thu, 14 Jan 2016 16:25:22 +0000 Received: by mail-yk0-f195.google.com with SMTP id v14so31275405ykd.1 for ; Thu, 14 Jan 2016 08:25:20 -0800 (PST) In-reply-to: <5697D80D02000078000C6DE9@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , Jonathan Creekmore , Dario Faggioli , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Jan Beulich writes: >>>> On 14.01.16 at 15:49, wrote: >> --- a/xen/common/schedule.c >> +++ b/xen/common/schedule.c >> @@ -64,20 +64,9 @@ static void poll_timer_fn(void *data); >> DEFINE_PER_CPU(struct schedule_data, schedule_data); >> DEFINE_PER_CPU(struct scheduler *, scheduler); >> >> -static const struct scheduler *schedulers[] = { >> -#ifdef CONFIG_SCHED_CREDIT >> - &sched_credit_def, >> -#endif >> -#ifdef CONFIG_SCHED_CREDIT2 >> - &sched_credit2_def, >> -#endif >> -#ifdef CONFIG_SCHED_ARINC653 >> - &sched_arinc653_def, >> -#endif >> -#ifdef CONFIG_SCHED_RTDS >> - &sched_rtds_def, >> -#endif >> -}; >> +extern const struct scheduler *__start_schedulers_array[], >> *__end_schedulers_array[]; >> +#define NUM_SCHEDULERS (__end_schedulers_array - __start_schedulers_array) >> +static const struct scheduler **schedulers = __start_schedulers_array; > > #define or properly constified (to help the compiler recognize it > won't ever change). I will make it a define in the next version.