All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor
Date: Mon, 28 Feb 2022 08:48:48 +0100	[thread overview]
Message-ID: <m31qzn8m8v.fsf@t19.piap.pl> (raw)
In-Reply-To: <YhjXEvtPlOv/jH4n@valkosipuli.retiisi.eu> (Sakari Ailus's message of "Fri, 25 Feb 2022 15:18:10 +0200")

Hi Sakari,

Sakari Ailus <sakari.ailus@iki.fi> writes:

>> >> +	// access the sensor only if it's powered up
>
> /* This is the preferred comment style */

I keep forgetting about this. Maybe because most other code I work with
(not drivers/media) has already switched to // (single-line) comments.

> The OF folks have shunned to the use of the iterative varants as that can
> often lead to complicated parsing of the endpoints. As obtaining the
> endpoint based on port and endpoint IDs works well in all cases I've
> suggested people to use that. But as the backend, at least currently, uses
> iterative functions, they're unlikely to disappear in the future.

I understand I should continue using fwnode_graph_get_endpoint_by_id(),
right?

Thanks.
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

  reply	other threads:[~2022-02-28  7:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 13:29 [PATCH v7 0/2] On Semi AR0521 sensor driver Krzysztof Hałasa
2022-01-03 13:32 ` [PATCH v7 1/2] dt-binding: media: document ON Semi AR0521 sensor bindings Krzysztof Hałasa
2022-01-03 13:36 ` [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor Krzysztof Hałasa
2022-01-09 15:34   ` Jacopo Mondi
2022-01-09 19:01     ` Joe Perches
2022-02-25 12:15     ` Krzysztof Hałasa
2022-02-25 13:18       ` Sakari Ailus
2022-02-28  7:48         ` Krzysztof Hałasa [this message]
2022-03-01  9:01       ` Jacopo Mondi
2022-03-01 12:19         ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31qzn8m8v.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=joe@perches.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.