From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59254 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PuMhH-0008Pz-07
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 05:20:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PuMhF-0008KG-Vd
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 05:20:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PuMhF-0008K8-ME
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 05:20:49 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p21AKmnW025145
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 1 Mar 2011 05:20:48 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1298972982-7609-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's
	message of "Tue, 1 Mar 2011 10:49:42 +0100")
References: <1298972982-7609-1-git-send-email-kwolf@redhat.com>
Date: Tue, 01 Mar 2011 11:19:16 +0100
Message-ID: <m31v2rgn2z.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH] Add error message for loading snapshot
	without VM state
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

Kevin Wolf <kwolf@redhat.com> wrote:
> It already fails, but it didn't tell the user why.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  savevm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index a50fd31..6e026a8 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1996,6 +1996,8 @@ int load_vmstate(const char *name)
>      if (ret < 0) {
>          return ret;
>      } else if (sn.vm_state_size == 0) {
> +        error_report("This is a disk-only snapshot. Revert to it offline "
> +            "using qemu-img.");
>          return -EINVAL;
>      }

Reviewed-by: Juan Quintela <quintela@redhat.com>