From: khalasa@piap.pl (Krzysztof Hałasa)
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>
Subject: Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)
Date: Tue, 27 Sep 2016 07:27:53 +0200 [thread overview]
Message-ID: <m337kldi92.fsf@t19.piap.pl> (raw)
In-Reply-To: <20160926091831.cp6qkv77oo5tinn5@zver> (Andrey Utkin's message of "Mon, 26 Sep 2016 12:18:31 +0300")
Andrey Utkin <andrey_utkin@fastmail.com> writes:
>> Does (only) adding the
>>
>> pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
>>
>> in solo_reg_write() help?
>
> Yes.
> I have posted a patch with this change few days ago, I thought you have
> noticed it.
Well, I think you haven't sent me a copy. Anyway, it would be great to
determine where exactly writes need a flush. Adding it everywhere is a
bit suboptimal, one would think.
Can you share some details about the machine you are experiencing the
problems on? CPU, chipset? I'd try to see if I can recreate the problem.
Alternatively, you could investigate yourself - at first you could put
pci_read_config_word() at the end of subroutines (including return
statements) using solo_reg_write(). And in that solo_p2m_dma_desc(),
before wait_for_completion_timeout(). Then eliminate them using some
sort of binary search to see which ones are required.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-09-27 5:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:04 solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin
2016-09-15 13:15 ` Hans Verkuil
2016-09-15 13:19 ` Andrey Utkin
2016-09-15 13:25 ` Hans Verkuil
2016-09-15 13:58 ` One Thousand Gnomes
2016-09-21 13:16 ` Krzysztof Hałasa
2016-09-21 13:45 ` Andrey Utkin
2016-09-22 8:51 ` Krzysztof Hałasa
2016-09-22 15:23 ` Andrey Utkin
2016-09-26 5:38 ` Krzysztof Hałasa
2016-09-26 9:18 ` Andrey Utkin
2016-09-27 5:27 ` Krzysztof Hałasa [this message]
2016-09-27 7:40 ` Andrey Utkin
2016-09-27 11:33 ` Krzysztof Hałasa
2016-09-27 14:22 ` Andrey Utkin
2016-09-28 5:21 ` Krzysztof Hałasa
2016-10-24 19:32 ` Mauro Carvalho Chehab
2016-10-24 20:56 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m337kldi92.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=andrey_utkin@fastmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael@iodev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.