From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ni.piap.pl ([195.187.100.4]:58043 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbcDDKhM (ORCPT ); Mon, 4 Apr 2016 06:37:12 -0400 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Tim Harvey Cc: Lucas Stach , Fabio Estevam , Petr =?utf-8?Q?=C5=A0tetiar?= , Richard Zhu , Bjorn Helgaas , "linux-pci\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , linux-kernel Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity References: <1459241739.2565.9.camel@pengutronix.de> <1459248921.2565.15.camel@pengutronix.de> Date: Mon, 04 Apr 2016 12:37:07 +0200 In-Reply-To: (Tim Harvey's message of "Thu, 31 Mar 2016 09:19:31 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-pci-owner@vger.kernel.org List-ID: Tim, > So perhaps there is something else going on with the tw8689 > device/driver that is causing it to not work with MSI. We have an > avc8000 miniPCIe with tw8689 here and can test if you send me your > patches that enable tw8689 with msi. I think you can use this: http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=tw686x > Regardless of MSI working in our tests we still disable it because of > it breaking legacy irqs and for performance reasons. So do I. However I'm also using Fedora 23 and this means I have to recompile the kernel, since they build it with MSI enabled. I think we should fix it, either by disabling in run time, or making it work. Performance-wise, I found it "surprising" that one can't have multiple MSIs with separate hw vector for each. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) Date: Mon, 04 Apr 2016 12:37:07 +0200 Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity In-Reply-To: (Tim Harvey's message of "Thu, 31 Mar 2016 09:19:31 -0700") References: <1459241739.2565.9.camel@pengutronix.de> <1459248921.2565.15.camel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tim, > So perhaps there is something else going on with the tw8689 > device/driver that is causing it to not work with MSI. We have an > avc8000 miniPCIe with tw8689 here and can test if you send me your > patches that enable tw8689 with msi. I think you can use this: http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=tw686x > Regardless of MSI working in our tests we still disable it because of > it breaking legacy irqs and for performance reasons. So do I. However I'm also using Fedora 23 and this means I have to recompile the kernel, since they build it with MSI enabled. I think we should fix it, either by disabling in run time, or making it work. Performance-wise, I found it "surprising" that one can't have multiple MSIs with separate hw vector for each. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland