From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57610 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PL50t-00042k-H5
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 21:23:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PL50s-0004Go-9k
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 21:23:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PL50s-0004Gg-1G
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 21:23:14 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1290522889-27559-11-git-send-email-agraf@suse.de> (Alexander
	Graf's message of "Tue, 23 Nov 2010 15:34:47 +0100")
References: <1290522889-27559-1-git-send-email-agraf@suse.de>
	<1290522889-27559-11-git-send-email-agraf@suse.de>
Date: Wed, 24 Nov 2010 03:22:31 +0100
Message-ID: <m339qrfok8.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 10/12] config: Add header file for device
	config options
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, Paul Brook <paul@codesourcery.com>, QEMU-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, tj@kernel.org, Sebastian Herbszt <herbszt@gmx.de>, Roland Elek <elek.roland@gmail.com>

Alexander Graf <agraf@suse.de> wrote:
> So far we have C preprocessor defines for target and host config
> options, but we're lacking any information on which devices are
> available.
>
> We do need that information at times though, for example in the
> ahci patch where we need to call a legacy init function depending
> on whether we have support compiled in or not.
>
> So this patch makes all config-devices options available as header
> file. Please only include it in machine description code!
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

This already existed in the past,  Paul Brook reverted it.

commit a992fe3d0fc185112677286f7a02204d8245b61e
Author: Paul Brook <paul@codesourcery.com>
Date:   Sun Nov 22 16:25:30 2009 +0000

    Makefile dependencies for device configs

I did the 1st implementation, and I tried to get it back several times.
Paul Brook reasoning is that "if you need it, our device model is wrong.

If you show that you want to be able to compile out several devices, ...

Paul Brook:  "if you need it, our device model is wrong"

If you don't want to have the abomination of xen-stub.c kvm-stub.c,
etc....

Paul Brook:  "if you need it, our device model is wrong".

Last time I tried to get it back was to be able to compile out hpet (it
didn't worked well at the time).

I let you guess how it ended.

Later, Juan.