From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55101 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWRBn-0004kt-0Q
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OWRBl-0006cr-M5
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3719)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OWRBl-0006cZ-Es
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:09 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1278418136-24556-1-git-send-email-armbru@redhat.com>
	<1278418136-24556-7-git-send-email-armbru@redhat.com>
	<20100707012609.GF2398@lst.de>
Date: Wed, 07 Jul 2010 11:41:16 +0200
In-Reply-To: <20100707012609.GF2398@lst.de> (Christoph Hellwig's message of
	"Wed, 7 Jul 2010 03:26:09 +0200")
Message-ID: <m339vvpr2b.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH v2 06/13] scsi: Reject unimplemented error
	actions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

Christoph Hellwig <hch@lst.de> writes:

> On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote:
>> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
>> we get it via if=none and -device.
>> 
>> Moreover, scsi-generic doesn't support werror.  Since drive_init()
>> doesn't catch that, option werror was silently ignored even with
>> if=scsi.
>> 
>> Wart: unlike drive_init(), we don't reject the default action when
>> it's explicitly specified.  That's because we can't distinguish "no
>> rerror option" from "rerror=report", or "no werror" from
>> "rerror=enospc".  Left for another day.
>
> I can't see a good reason that scsi doesn't support the rerror option,
> and implementing is trivial.  So while this patch looks correct I'd
> rather see rerror implemented for scsi than hacking around the lack of
> it.

You got a point there.  Same for fdc.

However, this is the best *I* can do in time for .13.  Let's add the
missin error action support after the release, okay?