All of lore.kernel.org
 help / color / mirror / Atom feed
From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP425: help on HSS channelized service
Date: Thu, 26 Nov 2009 20:03:26 +0100	[thread overview]
Message-ID: <m33a41un0h.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20091126144956.GA7150@n2100.arm.linux.org.uk> (Russell King's message of "Thu, 26 Nov 2009 14:49:56 +0000")

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

>> struct desc {
>>         u32 next;               /* pointer to next buffer, unused */
>> 
>> #ifdef __ARMEB__
>>         u16 buf_len;            /* buffer length */
>>         u16 pkt_len;            /* packet length */
>>         u32 data;               /* pointer to data buffer in RAM */
>>         u8 status;
>>         u8 error_count;
>>         u16 __reserved;
>> #else
>>         u16 pkt_len;            /* packet length */
>>         u16 buf_len;            /* buffer length */
>>         u32 data;               /* pointer to data buffer in RAM */
>>         u16 __reserved;
>>         u8 error_count;
>>         u8 status;
>> #endif
>>         u32 __reserved1[4];
>
> If these structures are sensitive to the byte-endian, they should be
> defined using [bl]e(32|16|8) so that sparse can check that you're
> using appropriate cpu_to_xxx() and xxx_to_cpu() endian conversions on
> them.

The values are in CPU order. I'll run sparse on this stuff, haven't done
that in a (too) long time.

It used to work in both LE and BE modes, though.
-- 
Krzysztof Halasa

  parent reply	other threads:[~2009-11-26 19:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 13:29 IXP425: help on HSS channelized service Davide Di Gesualdo
2009-11-24 15:22 ` Juergen Schindele
2009-11-25  0:07   ` Krzysztof Halasa
2009-11-25 12:52   ` Davide Di Gesualdo
2009-11-24 23:45 ` Krzysztof Halasa
2009-11-26 14:43   ` Juergen Schindele
2009-11-26 14:49     ` Russell King - ARM Linux
2009-11-26 15:44       ` Juergen Schindele
2009-11-26 15:51         ` Russell King - ARM Linux
2009-11-26 19:03       ` Krzysztof Halasa [this message]
2009-11-26 19:39     ` Krzysztof Halasa
2009-11-27  8:21       ` Juergen Schindele
2009-11-27 23:55         ` Krzysztof Halasa
2009-11-30  8:18           ` Juergen Schindele
  -- strict thread matches above, loose matches on Subject: below --
2009-11-25 13:34 Davide Di Gesualdo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33a41un0h.fsf@intrepid.localdomain \
    --to=khc@pm.waw.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.