From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm0JF-0001Ph-Rv for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qm0JE-0000F5-OM for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:21:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm0JE-0000F0-EA for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:21:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6R9LhCv011965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jul 2011 05:21:43 -0400 From: Markus Armbruster References: <1311685434-25282-1-git-send-email-alevy@redhat.com> <20110727070756.GZ2375@bow.redhat.com> Date: Wed, 27 Jul 2011 11:21:41 +0200 In-Reply-To: <20110727070756.GZ2375@bow.redhat.com> (Alon Levy's message of "Wed, 27 Jul 2011 10:07:56 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, hdegoede@redhat.com, yhalperi@redhat.com, quintela@redhat.com Alon Levy writes: > On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: >> Alon Levy writes: >> >> > Signed-off-by: Alon Levy >> > --- >> > hw/virtio-serial-bus.c | 8 +++++++- >> > 1 files changed, 7 insertions(+), 1 deletions(-) >> > >> > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c >> > index c5eb931..7a652ff 100644 >> > --- a/hw/virtio-serial-bus.c >> > +++ b/hw/virtio-serial-bus.c >> > @@ -618,14 +618,20 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id) >> > for (i = 0; i < nr_active_ports; i++) { >> > uint32_t id; >> > bool host_connected; >> > + VirtIOSerialPortInfo *info; >> > >> > id = qemu_get_be32(f); >> > port = find_port_by_id(s, id); >> > if (!port) { >> > return -EINVAL; >> > } >> > - >> > port->guest_connected = qemu_get_byte(f); >> > + info = DO_UPCAST(VirtIOSerialPortInfo, qdev, port->dev.info); >> > + if (port->guest_connected && info->guest_open) { >> > + /* replay guest open */ >> > + info->guest_open(port); >> > + >> > + } >> > host_connected = qemu_get_byte(f); >> > if (host_connected != port->host_connected) { >> > /* >> >> The patch makes enough sense to me, but the commit message is >> insufficient. Why do you have to replay? And what's being fixed? > > When migrating a host with with a spice agent running the mouse becomes > non operational after the migration. This is rhbz #718463, currently on > spice-server but it seems this is a qemu-kvm issue. The problem is that > after migration spice doesn't know the guest agent is open. Spice is just > a char dev here. And a chardev cannot query it's device, the device has > to let the chardev know when it is open. Right now after migration the > chardev which is recreated is in it's default state, which assumes the > guest is disconnected. Char devices carry no information across migration, > but the virtio-serial does already carry the guest_connected state. This > patch passes that bit to the chardev. Put this information in the commit message and resend?