From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55311 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PU3GV-0004JK-7G
	for qemu-devel@nongnu.org; Sat, 18 Dec 2010 15:20:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PU3GU-0004Jw-7t
	for qemu-devel@nongnu.org; Sat, 18 Dec 2010 15:20:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PU3GU-0004Iz-10
	for qemu-devel@nongnu.org; Sat, 18 Dec 2010 15:20:26 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1292689531-18763-3-git-send-email-andreas.faerber@web.de>
	("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Sat, 18 Dec 2010
	17:25:27 +0100")
References: <1292625556-24825-1-git-send-email-andreas.faerber@web.de>
	<1292689531-18763-1-git-send-email-andreas.faerber@web.de>
	<1292689531-18763-2-git-send-email-andreas.faerber@web.de>
	<1292689531-18763-3-git-send-email-andreas.faerber@web.de>
Date: Sun, 19 Dec 2010 01:49:26 +0530
Message-ID: <m34oaax29d.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v3 3/7] target-i386: Don't use SoftFloat
	uint64 type
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org, Huang Ying <ying.huang@intel.com>

Andreas F=C3=A4rber <andreas.faerber@web.de> wrote:
> softfloat.h's uint64 type has least-width semantics,
> which seems unintended here since uint64_t is used in helpers.
>
> v3:
> * Split off.

Acked-by: Juan Quintela <quintela@redhat.com>

Some days I feel the urgency of removing all the typealiases of
softfloat.h :(


> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Andreas F=C3=A4rber <andreas.faerber@web.de>
> ---
>  target-i386/cpu.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 06e40f3..f0c07cd 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -737,10 +737,10 @@ typedef struct CPUX86State {
>         user */
>      struct DeviceState *apic_state;
>=20=20
> -    uint64 mcg_cap;
> -    uint64 mcg_status;
> -    uint64 mcg_ctl;
> -    uint64 mce_banks[MCE_BANKS_DEF*4];
> +    uint64_t mcg_cap;
> +    uint64_t mcg_status;
> +    uint64_t mcg_ctl;
> +    uint64_t mce_banks[MCE_BANKS_DEF*4];
>=20=20
>      uint64_t tsc_aux;