From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nprh0-0000m2-LU for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:21:26 -0500 Received: from [199.232.76.173] (port=45355 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nprh0-0000lk-Bd for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:21:26 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nprgx-0005UH-UA for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:21:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14405) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nprgx-0005UB-FX for qemu-devel@nongnu.org; Thu, 11 Mar 2010 18:21:23 -0500 From: Juan Quintela In-Reply-To: <1268318923-13397-1-git-send-email-avi@redhat.com> (Avi Kivity's message of "Thu, 11 Mar 2010 16:48:43 +0200") References: <4B98FA68.7000901@codemonkey.ws> <1268318923-13397-1-git-send-email-avi@redhat.com> Date: Fri, 12 Mar 2010 00:21:13 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -49,6 +49,9 @@ and is therefore likely to be changed. > Typedefs are used to eliminate the redundant 'struct' keyword. It is the > QEMU coding style. > > +When wrapping standard library functions, use the prefix qemu_ to alert > +readers that they are seeing a wrapped version; otherwise avoid this prefix. > + > 4. Block structure > > Every indented statement is braced; even if the block contains just one Acked-by: Juan Quintela