All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Andreas Krey <a.krey@gmx.de>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	tzachi perelstein <tzachi_perelstein@yahoo.com>,
	git@vger.kernel.org
Subject: Re: git-describe recognize modified files
Date: Tue, 19 Jan 2010 04:49:40 -0800 (PST)	[thread overview]
Message-ID: <m34omiclap.fsf@localhost.localdomain> (raw)
In-Reply-To: <20100119122122.GA28667@inner.home.ulmdo.de>

Andreas Krey <a.krey@gmx.de> writes:

> On Tue, 19 Jan 2010 11:35:41 +0000, Johannes Schindelin wrote:
> ...
> > > To solve this issue, in addition to git-describe, my do_version script
> > > also run git-status, and if there are "modified:" files then it
> > > concatenates the string "+dirty" to output of git-describe.
> > 
> > The problem is that this does not describe the exact version you used very 
> > well.
> 
> I (and probably the original poster) don't care that much; for me the
> important information is that the binary (or whatever) was not built
> from the exact committed state. Thus the question is whether the
> second two lines of
> 
>  BUILDINFO=git-`git describe --abbrev=16 --always HEAD 2>/dev/null`
>  git update-index -q --refresh
>  test -z "`git diff-index --name-only HEAD --`" || BUILDINFO="$BUILDINFO.dirty"
> 
> (after GIT-VERSION-GEN) are worth to be integrated into git-describe?
> 
> (And whether it should also say '.dirty'
>  when there are untracked files present.
>  Or either for submodules.)

FYI it is integrated in git-describe since

  9f67d2e (Teach "git describe" --dirty option, 2009-10-21)

by Jean Privat (it should be present in 1.6.6, IIRC).

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2010-01-19 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19  9:53 git-describe recognize modified files tzachi perelstein
2010-01-19 10:35 ` Johannes Schindelin
2010-01-19 12:21   ` Andreas Krey
2010-01-19 12:49     ` Jakub Narebski [this message]
2010-01-19 13:07       ` tzachi perelstein
2010-01-19 12:59   ` tzachi perelstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34omiclap.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=a.krey@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=tzachi_perelstein@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.