From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NJWLB-0004S0-86
	for qemu-devel@nongnu.org; Sat, 12 Dec 2009 13:05:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NJWL6-0004Np-AQ
	for qemu-devel@nongnu.org; Sat, 12 Dec 2009 13:05:12 -0500
Received: from [199.232.76.173] (port=45157 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NJWL6-0004Ni-4R
	for qemu-devel@nongnu.org; Sat, 12 Dec 2009 13:05:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40112)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NJWL5-0004nm-NG
	for qemu-devel@nongnu.org; Sat, 12 Dec 2009 13:05:08 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names
	containing whitespace
References: <m3my1t2o00.fsf@crossbow.pond.sub.org>
	<4B1F6DCE.9090603@collabora.co.uk>
	<m3ein4zdmx.fsf@crossbow.pond.sub.org>
	<f43fc5580912120058g3a7d6ae9r85936a4d66c12562@mail.gmail.com>
Date: Sat, 12 Dec 2009 19:04:58 +0100
In-Reply-To: <f43fc5580912120058g3a7d6ae9r85936a4d66c12562@mail.gmail.com>
	(Blue Swirl's message of "Sat, 12 Dec 2009 10:58:53 +0200")
Message-ID: <m34onwcblh.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Ian Molton <ian.molton@collabora.co.uk>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Blue Swirl <blauwirbel@gmail.com> writes:

> On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster <armbru@redhat.com> wr=
ote:
>> Ian Molton <ian.molton@collabora.co.uk> writes:
>>
>>> Markus Armbruster wrote:
>>>
>>>> The place for verbose device names is DeviceInfo member desc. =C2=A0The
>>>> name should be short & sweet.
>>>
>>> Agreed, however...
>>>
>>> Why do these (maybe others) get caps in their names? they dont look
>>> right to me, compared to the others with nice names like usb-serial,
>>> piix-ide, or cirrus-vga.
>>>
>>>> - =C2=A0 =C2=A0sysbus_register_dev("Uni-north main", sizeof(UNINState),
>>>> + =C2=A0 =C2=A0sysbus_register_dev("Uni-north-main", sizeof(UNINState),
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0pci_unin_main_init_device);
>>>> =C2=A0 =C2=A0 =C2=A0pci_qdev_register(&unin_main_pci_host_info);
>>>> - =C2=A0 =C2=A0sysbus_register_dev("DEC 21154", sizeof(UNINState),
>>>> + =C2=A0 =C2=A0sysbus_register_dev("DEC-21154", sizeof(UNINState),
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0pci_dec_21154_init_device);
>>>> =C2=A0 =C2=A0 =C2=A0pci_qdev_register(&dec_21154_pci_host_info);
>>>> - =C2=A0 =C2=A0sysbus_register_dev("Uni-north AGP", sizeof(UNINState),
>>>> + =C2=A0 =C2=A0sysbus_register_dev("Uni-north-AGP", sizeof(UNINState),
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0pci_unin_agp_init_device);
>>>> =C2=A0 =C2=A0 =C2=A0pci_qdev_register(&unin_agp_pci_host_info);
>>>> - =C2=A0 =C2=A0sysbus_register_dev("Uni-north internal", sizeof(UNINSt=
ate),
>>>> + =C2=A0 =C2=A0sysbus_register_dev("Uni-north-internal", sizeof(UNINSt=
ate),
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0pci_unin_internal_init_device);
>>>> =C2=A0 =C2=A0 =C2=A0pci_qdev_register(&unin_internal_pci_host_info);
>>>> =C2=A0}
>>
>> I can downcase them. =C2=A0Blue Swirl, any objections?
>>
>
> I'd prefer the same names that are used by the device tree, like uni-n
> and uni-north-agp. Though the bridge is name poorly, just
> "pci-bridge".
>
> For example:
> http://penguinppc.org/historical/dev-trees-html/imac_400_1.html

If I read that document correctly, we have

    old qdev name               device tree name
    Uni-north main              uni-n
    Uni-north AGP               uni-north-agp
    Uni-north internal          pci
    DEC 21154                   pci-bridge

Do you want me to respin my patch?  If yes, the best way to make me do
exactly what you want is to tell me exactly what you want.  In this
case, tell me the names you want.