From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCb19-0001mr-IH
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 10:39:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCb14-0001jm-Hq
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 10:39:54 -0500
Received: from [199.232.76.173] (port=42652 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCb14-0001jf-CH
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 10:39:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40184)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NCb12-00064E-Rq
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 10:39:49 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nANFdkFc025280
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 23 Nov 2009 10:39:46 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 12/17] char: Convert qemu_chr_info() to
	QObject
References: <1258489944-12159-1-git-send-email-lcapitulino@redhat.com>
	<1258489944-12159-13-git-send-email-lcapitulino@redhat.com>
	<m3ocmxqoc3.fsf@crossbow.pond.sub.org>
	<20091123112331.6ad22f22@doriath>
Date: Mon, 23 Nov 2009 16:39:44 +0100
In-Reply-To: <20091123112331.6ad22f22@doriath> (Luiz Capitulino's message of
	"Mon, 23 Nov 2009 11:23:31 -0200")
Message-ID: <m34oolxnb3.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Fri, 20 Nov 2009 15:10:20 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> writes:
>> 
>> > Each device is represented by a QDict. The returned QObject is a QList
>> > of all devices.
>> >
>> > This commit should not change user output.
>> >
>> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>> > ---
>> >  monitor.c   |    3 ++-
>> >  qemu-char.c |   43 +++++++++++++++++++++++++++++++++++++++++--
>> >  qemu-char.h |    4 +++-
>> >  3 files changed, 46 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/monitor.c b/monitor.c
>> > index e4fed10..a0a9281 100644
>> > --- a/monitor.c
>> > +++ b/monitor.c
[...]
>> > @@ -2465,13 +2466,51 @@ void qemu_chr_close(CharDriverState *chr)
>> >      qemu_free(chr);
>> >  }
>> >  
>> > -void qemu_chr_info(Monitor *mon)
>> > +static void qemu_chr_print_qlist(QObject *obj, void *opaque)
>> 
>> Why *_qlist?  It prints a qdict, which happens to be a list element, but
>> this function doesn't know that.
>
>  It does know, as it was written with the purpose of printing the elements
> of a qlist.

You knew it when you wrote it, but the function itself has nothing to do
with lists.

Elsewhere, you call such functions *_dict(), which makes sense to me,
because it prints a dictionary, or *_iter(), which I is also okay.