Re: [PATCH 05/16] ls-files: add --narrow-checkout option to "will checkout" entries

[Jakub Narebski <jnareb@gmail.com>]

I will comment only on the documentation...

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> Even in narrow checkout mode, "git ls-files --cached" (and --stage)
> will show all entries in index. When those options are used together
> with --narrow-checkout, no-checkout entries will be skipped.
> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 9f85d60..f74b212 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -72,6 +73,11 @@ OPTIONS
>  	to file/directory conflicts for checkout-index to
>  	succeed.
>  
> +--narrow-checkout::
> +	When narrow checkout is being used, this option together with other
> +	index-based selection options like --cached or --stage, only narrowed
> +	portion will be printed out.
> +

I would rather say, that if git-ls-files is requested to show index
content (by using selection options like --cached or --stage), then
by default it shows all entries, also those marked "no checkout".
With this option git-ls-files would show only files that would get
checked out.

BTW. I think here --narrow-checkout is a good name, even though
I prefer 'partial checkout' or 'sparse checkout', because here it
is about narrowing the list of paths from index shown.

-- 
Jakub Narebski
Poland
ShadeHawk on #git