From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rui Miguel Silva Subject: Re: [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver Date: Fri, 07 Dec 2018 13:54:05 +0000 Message-ID: References: <20181122151834.6194-1-rui.silva@linaro.org> <20181122151834.6194-6-rui.silva@linaro.org> <5bc1ad92-4d84-62af-396c-9ba8b3be424b@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <5bc1ad92-4d84-62af-396c-9ba8b3be424b@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Hans Verkuil Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, sakari.ailus@linux.intel.com, Greg Kroah-Hartman , Philipp Zabel , Steve Longerbeam , linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Hans, On Fri 07 Dec 2018 at 12:39, Hans Verkuil wrote: > On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: >> Add bindings documentation for i.MX7 media drivers. >> The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. >> >> Signed-off-by: Rui Miguel Silva >> Reviewed-by: Rob Herring >> Acked-by: Sakari Ailus > > Please move this patch to the beginning of the series to avoid > checkpatch warnings: > > WARNING: DT compatible string "fsl,imx7-csi" appears > un-documented -- check ./Documentation/devicetree/bindings/ > #1378: FILE: drivers/staging/media/imx/imx7-media-csi.c:1336: > + { .compatible = "fsl,imx7-csi" }, Will do, thanks for catching this one. --- Cheers, Rui > > Thanks! > > Hans > > >> --- >> .../devicetree/bindings/media/imx7-csi.txt | 45 ++++++++++ >> .../bindings/media/imx7-mipi-csi2.txt | 90 >> +++++++++++++++++++ >> 2 files changed, 135 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/imx7-csi.txt >> create mode 100644 >> Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> >> diff --git >> a/Documentation/devicetree/bindings/media/imx7-csi.txt >> b/Documentation/devicetree/bindings/media/imx7-csi.txt >> new file mode 100644 >> index 000000000000..3c07bc676bc3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt >> @@ -0,0 +1,45 @@ >> +Freescale i.MX7 CMOS Sensor Interface >> +===================================== >> + >> +csi node >> +-------- >> + >> +This is device node for the CMOS Sensor Interface (CSI) which >> enables the chip >> +to connect directly to external CMOS image sensors. >> + >> +Required properties: >> + >> +- compatible : "fsl,imx7-csi"; >> +- reg : base address and length of the register set >> for the device; >> +- interrupts : should contain CSI interrupt; >> +- clocks : list of clock specifiers, see >> + >> Documentation/devicetree/bindings/clock/clock-bindings.txt for >> details; >> +- clock-names : must contain "axi", "mclk" and "dcic" >> entries, matching >> + entries in the clock property; >> + >> +The device node shall contain one 'port' child node with one >> child 'endpoint' >> +node, according to the bindings defined in: >> +Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +In the following example a remote endpoint is a video >> multiplexer. >> + >> +example: >> + >> + csi: csi@30710000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + compatible = "fsl,imx7-csi"; >> + reg = <0x30710000 0x10000>; >> + interrupts = > IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&clks IMX7D_CLK_DUMMY>, >> + <&clks >> IMX7D_CSI_MCLK_ROOT_CLK>, >> + <&clks >> IMX7D_CLK_DUMMY>; >> + clock-names = "axi", "mclk", "dcic"; >> + >> + port { >> + csi_from_csi_mux: endpoint { >> + remote-endpoint = >> <&csi_mux_to_csi>; >> + }; >> + }; >> + }; >> diff --git >> a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> new file mode 100644 >> index 000000000000..71fd74ed3ec8 >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> @@ -0,0 +1,90 @@ >> +Freescale i.MX7 Mipi CSI2 >> +========================= >> + >> +mipi_csi2 node >> +-------------- >> + >> +This is the device node for the MIPI CSI-2 receiver core in >> i.MX7 SoC. It is >> +compatible with previous version of Samsung D-phy. >> + >> +Required properties: >> + >> +- compatible : "fsl,imx7-mipi-csi2"; >> +- reg : base address and length of the register set >> for the device; >> +- interrupts : should contain MIPI CSIS interrupt; >> +- clocks : list of clock specifiers, see >> + >> Documentation/devicetree/bindings/clock/clock-bindings.txt for >> details; >> +- clock-names : must contain "pclk", "wrap" and "phy" >> entries, matching >> + entries in the clock property; >> +- power-domains : a phandle to the power domain, see >> + >> Documentation/devicetree/bindings/power/power_domain.txt for >> details. >> +- reset-names : should include following entry "mrst"; >> +- resets : a list of phandle, should contain reset >> entry of >> + reset-names; >> +- phy-supply : from the generic phy bindings, a phandle to >> a regulator that >> + provides power to MIPI CSIS core; >> + >> +Optional properties: >> + >> +- clock-frequency : The IP's main (system bus) clock frequency >> in Hz, default >> + value when this property is not specified is >> 166 MHz; >> +- fsl,csis-hs-settle : differential receiver (HS-RX) settle >> time; >> + >> +The device node should contain two 'port' child nodes with one >> child 'endpoint' >> +node, according to the bindings defined in: >> + Documentation/devicetree/bindings/ >> media/video-interfaces.txt. >> + The following are properties specific to those nodes. >> + >> +port node >> +--------- >> + >> +- reg : (required) can take the values 0 or 1, >> where 0 shall be >> + related to the sink port and port 1 shall >> be the source >> + one; >> + >> +endpoint node >> +------------- >> + >> +- data-lanes : (required) an array specifying active >> physical MIPI-CSI2 >> + data input lanes and their mapping to logical >> lanes; this >> + shall only be applied to port 0 (sink >> port), the array's >> + content is unused only its length is >> meaningful, >> + in this case the maximum length supported >> is 2; >> + >> +example: >> + >> + mipi_csi: mipi-csi@30750000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + compatible = "fsl,imx7-mipi-csi2"; >> + reg = <0x30750000 0x10000>; >> + interrupts = ; >> + clocks = <&clks IMX7D_IPG_ROOT_CLK>, >> + <&clks >> IMX7D_MIPI_CSI_ROOT_CLK>, >> + <&clks >> IMX7D_MIPI_DPHY_ROOT_CLK>; >> + clock-names = "pclk", "wrap", "phy"; >> + clock-frequency = <166000000>; >> + power-domains = <&pgc_mipi_phy>; >> + phy-supply = <®_1p0d>; >> + resets = <&src IMX7_RESET_MIPI_PHY_MRST>; >> + reset-names = "mrst"; >> + fsl,csis-hs-settle = <3>; >> + >> + port@0 { >> + reg = <0>; >> + >> + mipi_from_sensor: endpoint { >> + remote-endpoint = >> <&ov2680_to_mipi>; >> + data-lanes = <1>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + mipi_vc0_to_csi_mux: endpoint { >> + remote-endpoint = >> <&csi_mux_from_mipi_vc0>; >> + }; >> + }; >> + }; >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F187CC07E85 for ; Fri, 7 Dec 2018 13:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD51F20989 for ; Fri, 7 Dec 2018 13:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="VvZG/ywl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD51F20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbeLGNyK (ORCPT ); Fri, 7 Dec 2018 08:54:10 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39260 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeLGNyK (ORCPT ); Fri, 7 Dec 2018 08:54:10 -0500 Received: by mail-wr1-f66.google.com with SMTP id t27so3880834wra.6 for ; Fri, 07 Dec 2018 05:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=PuyDrKsx0Jmeq58JQ62rT+y23TR+FgRQT+zFMVU8FaU=; b=VvZG/ywljW/rzRgq0Nc+n+0eSbSBIaVcIbmzx59yddwKeRWHiy07njHdLj6Wynz5hs wzJXrrpX+e11jeqxDxr3PLJutEWUzQ8BmwMAa5YqRKcGnAnh8U7EajzKzrJzH1TgmVxW 3cYr8CIEuQ8+m3dvzoPAwaXURW9mfTJOc2t04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=PuyDrKsx0Jmeq58JQ62rT+y23TR+FgRQT+zFMVU8FaU=; b=uJoldhbNqjgm4zPT0BwIWqrcywGE9ggqR3MPJ37Dcn4zEkzH9hgv5ZSpHXGmhpfHom ifhuNPXSuJTBc4mhqXjkPtY4JOPivIXDbk+8Ar2ehkYEA9hNy2nGG4ayaw7Sf03Yb8Zk gH8diW0SyhkJTzmdaXnILccevAOImd6d78F5bpdQZ8ZsykGin25GUmHMYYxn1P/g3iC1 WqQw6k/byGQW7wJJbSYCdtvxKaEFhbF2/aZrVqfa9S+k0pYEkFARGofkKywEXBcQGalS 5DftiOcwg7eLkUPjwOogQ0aLSXUXtr/y7Lx3+W7F6G8TQUspY0b3bk8As2XWcUQxXxcZ SWWA== X-Gm-Message-State: AA+aEWbvj0sW2g9lq81pTbY9Kmm1qZEEk4jC2kwqQYZ2OLm4RJMVtzim Hyk/1AaXvz64HgsWs7wKOuRqfg== X-Google-Smtp-Source: AFSGD/WFl1pvhREElsoRGrFCZEmufyRPiBhcc0hNz+XknkkNSdp3utQOBmnTXB0rx6/ksqtorLFhJQ== X-Received: by 2002:adf:9205:: with SMTP id 5mr1879321wrj.189.1544190847040; Fri, 07 Dec 2018 05:54:07 -0800 (PST) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id r64sm4595331wmg.5.2018.12.07.05.54.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Dec 2018 05:54:06 -0800 (PST) References: <20181122151834.6194-1-rui.silva@linaro.org> <20181122151834.6194-6-rui.silva@linaro.org> <5bc1ad92-4d84-62af-396c-9ba8b3be424b@xs4all.nl> User-agent: mu4e 1.0; emacs 27.0.50 From: Rui Miguel Silva To: Hans Verkuil Cc: sakari.ailus@linux.intel.com, Steve Longerbeam , Philipp Zabel , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver In-reply-to: <5bc1ad92-4d84-62af-396c-9ba8b3be424b@xs4all.nl> Date: Fri, 07 Dec 2018 13:54:05 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hans, On Fri 07 Dec 2018 at 12:39, Hans Verkuil wrote: > On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: >> Add bindings documentation for i.MX7 media drivers. >> The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. >> >> Signed-off-by: Rui Miguel Silva >> Reviewed-by: Rob Herring >> Acked-by: Sakari Ailus > > Please move this patch to the beginning of the series to avoid > checkpatch warnings: > > WARNING: DT compatible string "fsl,imx7-csi" appears > un-documented -- check ./Documentation/devicetree/bindings/ > #1378: FILE: drivers/staging/media/imx/imx7-media-csi.c:1336: > + { .compatible = "fsl,imx7-csi" }, Will do, thanks for catching this one. --- Cheers, Rui > > Thanks! > > Hans > > >> --- >> .../devicetree/bindings/media/imx7-csi.txt | 45 ++++++++++ >> .../bindings/media/imx7-mipi-csi2.txt | 90 >> +++++++++++++++++++ >> 2 files changed, 135 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/imx7-csi.txt >> create mode 100644 >> Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> >> diff --git >> a/Documentation/devicetree/bindings/media/imx7-csi.txt >> b/Documentation/devicetree/bindings/media/imx7-csi.txt >> new file mode 100644 >> index 000000000000..3c07bc676bc3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/imx7-csi.txt >> @@ -0,0 +1,45 @@ >> +Freescale i.MX7 CMOS Sensor Interface >> +===================================== >> + >> +csi node >> +-------- >> + >> +This is device node for the CMOS Sensor Interface (CSI) which >> enables the chip >> +to connect directly to external CMOS image sensors. >> + >> +Required properties: >> + >> +- compatible : "fsl,imx7-csi"; >> +- reg : base address and length of the register set >> for the device; >> +- interrupts : should contain CSI interrupt; >> +- clocks : list of clock specifiers, see >> + >> Documentation/devicetree/bindings/clock/clock-bindings.txt for >> details; >> +- clock-names : must contain "axi", "mclk" and "dcic" >> entries, matching >> + entries in the clock property; >> + >> +The device node shall contain one 'port' child node with one >> child 'endpoint' >> +node, according to the bindings defined in: >> +Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +In the following example a remote endpoint is a video >> multiplexer. >> + >> +example: >> + >> + csi: csi@30710000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + compatible = "fsl,imx7-csi"; >> + reg = <0x30710000 0x10000>; >> + interrupts = > IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&clks IMX7D_CLK_DUMMY>, >> + <&clks >> IMX7D_CSI_MCLK_ROOT_CLK>, >> + <&clks >> IMX7D_CLK_DUMMY>; >> + clock-names = "axi", "mclk", "dcic"; >> + >> + port { >> + csi_from_csi_mux: endpoint { >> + remote-endpoint = >> <&csi_mux_to_csi>; >> + }; >> + }; >> + }; >> diff --git >> a/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> new file mode 100644 >> index 000000000000..71fd74ed3ec8 >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/media/imx7-mipi-csi2.txt >> @@ -0,0 +1,90 @@ >> +Freescale i.MX7 Mipi CSI2 >> +========================= >> + >> +mipi_csi2 node >> +-------------- >> + >> +This is the device node for the MIPI CSI-2 receiver core in >> i.MX7 SoC. It is >> +compatible with previous version of Samsung D-phy. >> + >> +Required properties: >> + >> +- compatible : "fsl,imx7-mipi-csi2"; >> +- reg : base address and length of the register set >> for the device; >> +- interrupts : should contain MIPI CSIS interrupt; >> +- clocks : list of clock specifiers, see >> + >> Documentation/devicetree/bindings/clock/clock-bindings.txt for >> details; >> +- clock-names : must contain "pclk", "wrap" and "phy" >> entries, matching >> + entries in the clock property; >> +- power-domains : a phandle to the power domain, see >> + >> Documentation/devicetree/bindings/power/power_domain.txt for >> details. >> +- reset-names : should include following entry "mrst"; >> +- resets : a list of phandle, should contain reset >> entry of >> + reset-names; >> +- phy-supply : from the generic phy bindings, a phandle to >> a regulator that >> + provides power to MIPI CSIS core; >> + >> +Optional properties: >> + >> +- clock-frequency : The IP's main (system bus) clock frequency >> in Hz, default >> + value when this property is not specified is >> 166 MHz; >> +- fsl,csis-hs-settle : differential receiver (HS-RX) settle >> time; >> + >> +The device node should contain two 'port' child nodes with one >> child 'endpoint' >> +node, according to the bindings defined in: >> + Documentation/devicetree/bindings/ >> media/video-interfaces.txt. >> + The following are properties specific to those nodes. >> + >> +port node >> +--------- >> + >> +- reg : (required) can take the values 0 or 1, >> where 0 shall be >> + related to the sink port and port 1 shall >> be the source >> + one; >> + >> +endpoint node >> +------------- >> + >> +- data-lanes : (required) an array specifying active >> physical MIPI-CSI2 >> + data input lanes and their mapping to logical >> lanes; this >> + shall only be applied to port 0 (sink >> port), the array's >> + content is unused only its length is >> meaningful, >> + in this case the maximum length supported >> is 2; >> + >> +example: >> + >> + mipi_csi: mipi-csi@30750000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + compatible = "fsl,imx7-mipi-csi2"; >> + reg = <0x30750000 0x10000>; >> + interrupts = ; >> + clocks = <&clks IMX7D_IPG_ROOT_CLK>, >> + <&clks >> IMX7D_MIPI_CSI_ROOT_CLK>, >> + <&clks >> IMX7D_MIPI_DPHY_ROOT_CLK>; >> + clock-names = "pclk", "wrap", "phy"; >> + clock-frequency = <166000000>; >> + power-domains = <&pgc_mipi_phy>; >> + phy-supply = <®_1p0d>; >> + resets = <&src IMX7_RESET_MIPI_PHY_MRST>; >> + reset-names = "mrst"; >> + fsl,csis-hs-settle = <3>; >> + >> + port@0 { >> + reg = <0>; >> + >> + mipi_from_sensor: endpoint { >> + remote-endpoint = >> <&ov2680_to_mipi>; >> + data-lanes = <1>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + mipi_vc0_to_csi_mux: endpoint { >> + remote-endpoint = >> <&csi_mux_from_mipi_vc0>; >> + }; >> + }; >> + }; >>