From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index Date: Mon, 20 Dec 2010 18:00:34 +0100 Message-ID: References: <4D0EF37B.1040702@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Luiz Capitulino , qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org, Avi Kivity To: Lai Jiangshan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55555 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932676Ab0LTRAl (ORCPT ); Mon, 20 Dec 2010 12:00:41 -0500 In-Reply-To: <4D0EF37B.1040702@cn.fujitsu.com> (Lai Jiangshan's message of "Mon, 20 Dec 2010 14:11:07 +0800") Sender: kvm-owner@vger.kernel.org List-ID: Lai Jiangshan writes: > "cpu-index" is better name. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 4befbe2..8de7aa3 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -721,7 +721,7 @@ ETEXI > #if defined(TARGET_I386) > { > .name = "nmi", > - .args_type = "cpu_index:i", > + .args_type = "cpu-index:i", > .params = "cpu", > .help = "inject an NMI on the given CPU", > .mhandler.cmd = do_inject_nmi, > diff --git a/monitor.c b/monitor.c > index 5d74fe3..c16b39d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict) > static void do_inject_nmi(Monitor *mon, const QDict *qdict) > { > CPUState *env; > - int cpu_index = qdict_get_int(qdict, "cpu_index"); > + int cpu_index = qdict_get_int(qdict, "cpu-index"); > > for (env = first_cpu; env != NULL; env = env->next_cpu) > if (env->cpu_index == cpu_index) { Fine with me, but it would be nice if we could make up our mind once and for all whether to use dash or underscore in monitor commands and arguments. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56174 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUj6g-0002Oz-BF for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:02:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUj6G-00080A-79 for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:01:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUj6F-0007zv-VQ for qemu-devel@nongnu.org; Mon, 20 Dec 2010 12:00:40 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 1/3] nmi: convert cpu_index to cpu-index References: <4D0EF37B.1040702@cn.fujitsu.com> Date: Mon, 20 Dec 2010 18:00:34 +0100 In-Reply-To: <4D0EF37B.1040702@cn.fujitsu.com> (Lai Jiangshan's message of "Mon, 20 Dec 2010 14:11:07 +0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lai Jiangshan Cc: aliguori@us.ibm.com, Avi Kivity , qemu-devel@nongnu.org, kvm@vger.kernel.org, Luiz Capitulino Lai Jiangshan writes: > "cpu-index" is better name. > > Signed-off-by: Lai Jiangshan > --- > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 4befbe2..8de7aa3 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -721,7 +721,7 @@ ETEXI > #if defined(TARGET_I386) > { > .name = "nmi", > - .args_type = "cpu_index:i", > + .args_type = "cpu-index:i", > .params = "cpu", > .help = "inject an NMI on the given CPU", > .mhandler.cmd = do_inject_nmi, > diff --git a/monitor.c b/monitor.c > index 5d74fe3..c16b39d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -2410,7 +2410,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict) > static void do_inject_nmi(Monitor *mon, const QDict *qdict) > { > CPUState *env; > - int cpu_index = qdict_get_int(qdict, "cpu_index"); > + int cpu_index = qdict_get_int(qdict, "cpu-index"); > > for (env = first_cpu; env != NULL; env = env->next_cpu) > if (env->cpu_index == cpu_index) { Fine with me, but it would be nice if we could make up our mind once and for all whether to use dash or underscore in monitor commands and arguments.