From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx Date: Fri, 03 Sep 2010 15:11:20 +0200 Message-ID: References: <20100902150041.11862.65901.stgit@s20.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, anthony@codemonkey.ws, mst@redhat.com, chrisw@redhat.com, jes.sorensen@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597Ab0ICNN4 (ORCPT ); Fri, 3 Sep 2010 09:13:56 -0400 In-Reply-To: <20100902150041.11862.65901.stgit@s20.home> (Alex Williamson's message of "Thu, 02 Sep 2010 09:00:42 -0600") Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > Incorporated feedback. txburst= and txtimer= are now "x-" prefixed > developer options. I added a tx= option, because I do want there to > be a supported way to switch between TX strategies. This also drops > the magic value of txtimer= 1 or 0 (setting default timeout or switching > modes). I also dropped the trickiness around only enabling the bottom > half for the iothread since Anthony indicates we don't care about > performance for the non-iothread case. > > New performance data against both qemu.git and qemu-kvm.git: > > https://spreadsheets.google.com/pub?key=0AoEm50Bac2U7dGdlREhrWUpPVEdMcTJaX0RjSEgtc3c&hl=en&single=true&gid=0&output=html > > This shows the base performance versus patched with new default for > various packet sizes and netperf test loads. The guest is a 2-way > SMP, connected directly to the host via a tap (no bridge). Thanks, > > Alex Acked-by: Juan Quintela (whole series) Thanks very much for the cleanups, I think it is clearer nicer now. Later, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50778 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OrW6x-0002qX-RH for qemu-devel@nongnu.org; Fri, 03 Sep 2010 09:15:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OrW5S-0003qF-J7 for qemu-devel@nongnu.org; Fri, 03 Sep 2010 09:13:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23867) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OrW5S-0003px-Bw for qemu-devel@nongnu.org; Fri, 03 Sep 2010 09:13:46 -0400 From: Juan Quintela In-Reply-To: <20100902150041.11862.65901.stgit@s20.home> (Alex Williamson's message of "Thu, 02 Sep 2010 09:00:42 -0600") References: <20100902150041.11862.65901.stgit@s20.home> Date: Fri, 03 Sep 2010 15:11:20 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: chrisw@redhat.com, kvm@vger.kernel.org, mst@redhat.com, jes.sorensen@redhat.com, qemu-devel@nongnu.org Alex Williamson wrote: > Incorporated feedback. txburst= and txtimer= are now "x-" prefixed > developer options. I added a tx= option, because I do want there to > be a supported way to switch between TX strategies. This also drops > the magic value of txtimer= 1 or 0 (setting default timeout or switching > modes). I also dropped the trickiness around only enabling the bottom > half for the iothread since Anthony indicates we don't care about > performance for the non-iothread case. > > New performance data against both qemu.git and qemu-kvm.git: > > https://spreadsheets.google.com/pub?key=0AoEm50Bac2U7dGdlREhrWUpPVEdMcTJaX0RjSEgtc3c&hl=en&single=true&gid=0&output=html > > This shows the base performance versus patched with new default for > various packet sizes and netperf test loads. The guest is a 2-way > SMP, connected directly to the host via a tap (no bridge). Thanks, > > Alex Acked-by: Juan Quintela (whole series) Thanks very much for the cleanups, I think it is clearer nicer now. Later, Juan.