All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 5/8] t/README: Document test_external*
Date: Thu, 01 Jul 2010 13:52:26 -0700 (PDT)	[thread overview]
Message-ID: <m3630zncwx.fsf@localhost.localdomain> (raw)
In-Reply-To: <1278015478-6920-6-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> + - test_external [<prereq>] <message> <external> <script>
> +
> +   Execute a <script> with an <external> interpreter (like perl). This
> +   was added for tests like t9700-perl-git.sh which do most of their
> +   work in an external test script.
> +
> +	test_external_without_stderr \
> +	    'Perl API' \
> +	    "$PERL_PATH" "$TEST_DIRECTORY"/t9700/test.pl

I think this example was to be about 'test_external'; currently it
duplicates example for 'test_external_without_stderr'.

Perhaps:

  +     test_external \
  +         'GitwebCache::*FileCache*' \
  +         "$PERL_PATH" "$TEST_DIRECTORY"/t9503/test_cache_interface.pl

> + - test_external_without_stderr [<prereq>] <message> <external> <script>
> +
> +   Like test_external but fail if there's any output on stderr,
> +   instead of checking the exit code.
> +
> +	test_external_without_stderr \
> +	    'Perl API' \
> +	    "$PERL_PATH" "$TEST_DIRECTORY"/t9700/test.pl

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2010-07-01 20:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 20:17 [PATCH v2 0/8] Improvements for t/README Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 1/8] t/README: Tests are all +x, ./test, not sh ./test Ævar Arnfjörð Bjarmason
2010-07-01 23:54   ` Junio C Hamano
2010-07-02  1:00     ` Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 2/8] t/README: The trash is in 't/trash directory.$name' Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 3/8] t/README: Typo: paralell -> parallel Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 4/8] t/README: Document the prereq functions, and 3-arg test_* Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 5/8] t/README: Document test_external* Ævar Arnfjörð Bjarmason
2010-07-01 20:52   ` Jakub Narebski [this message]
2010-07-01 21:18     ` [PATCH v3 " Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 6/8] t/README: Document test_expect_code Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 7/8] t/README: Add a section about skipping tests Ævar Arnfjörð Bjarmason
2010-07-01 20:17 ` [PATCH v2 8/8] t/README: Document the do's and don'ts of tests Ævar Arnfjörð Bjarmason
2010-07-02  7:28 ` [PATCH v2 0/8] Improvements for t/README Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3630zncwx.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.