From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39909 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOsOz-0002Dc-DL
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:11:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OOsOu-0001TT-Vb
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:11:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6042)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OOsOu-0001TF-OB
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:11:28 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1276619430-15871-7-git-send-email-aliguori@us.ibm.com> (Anthony
	Liguori's message of "Tue, 15 Jun 2010 11:30:26 -0500")
References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com>
	<1276619430-15871-7-git-send-email-aliguori@us.ibm.com>
Date: Wed, 16 Jun 2010 15:11:24 +0200
Message-ID: <m3631jnmv7.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [CFR 6/10] cont command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>

Anthony Liguori <aliguori@us.ibm.com> wrote:
> cont
> ----
>
> Resume emulation.
>
> Arguments: None.
>
> Example:
>
> -> { "execute": "cont" }
> <- { "return": {} }

This is related to the commands, not QMP per se:

Once that we are talking about "cont" command.  There are two cases that
we need to think of:

- incoming migration:

If you start with -incoming foo, and then run "cont" on the monitor
without having started the migration .... corruption is ensured.

- outgoing migration

After sucessful migration, we can issue "cont" command in source, and
having source and target running at the same time -> disk corruption
again.

My suggestion:
- add a third state "incoming", and cont/stop don't work on that state
- add a fourth state "migrated", and "cont" gives an explicit error, and you
  have to run "cont --force" or "cont" twice (whatever) to get it to continue.

Later, Juan.