All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@trasno.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie
Date: Tue, 15 Dec 2009 21:55:33 +0100	[thread overview]
Message-ID: <m36388neii.fsf@neno.neno> (raw)
In-Reply-To: <cc557aab0912151148v2a98d2b2n7dd67fdb23388cd6@mail.gmail.com> (Kirill A. Shutemov's message of "Tue, 15 Dec 2009 21:48:00 +0200")

"Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> Please, apply it.
>
> On Tue, Dec 15, 2009 at 3:10 AM, Kirill A. Shutemov
> <kirill@shutemov.name> wrote:
>> We really need compile _all_ sources for user target with -fpie when
>> use --enable-user-pie.
>>
>> It's regression introduced by commit add16157d72454.
>> Please, do not break it any more.

Wishful thinking :p
I bet that:
a- Blue Swirl didn't do it on purpose
b- our build system is very fragile, it will happens again. 

Learn to live with it.

>> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> ---
>>  Makefile.user |    4 ++--
>>  configure     |    1 +
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.user b/Makefile.user
>> index 907e74b..0be73df 100644
>> --- a/Makefile.user
>> +++ b/Makefile.user
>> @@ -5,9 +5,9 @@ include $(SRC_PATH)/rules.mak
>>
>>  .PHONY: all
>>
>> -VPATH=$(SRC_PATH)
>> +vpath %.c $(SRC_PATH)

This change is needed?

>>
>> -QEMU_CFLAGS+=-I..
>> +QEMU_CFLAGS+=-I$(SRC_PATH)/ $(CFLAGS_PIE)

Why do you change it?

QEMU_CFLAGS has this value in configure
QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"

>>
>>  obj-y =
>>  obj-y += envlist.o path.o
>> diff --git a/configure b/configure
>> index 273b6b7..6200391 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2555,6 +2555,7 @@ if test "$target_user_only" = "yes" -a "$static" = "no" -a \
>>        "$user_pie" = "yes" ; then
>>   cflags="-fpie $cflags"
>>   ldflags="-pie $ldflags"
>> +  echo "CFLAGS_PIE=-fpie" >> $config_host_mak
>>  fi
>>
>>  if test "$target_softmmu" = "yes" -a \( \
>> --
>> 1.6.5.6
>>
>>

Can you test this other patch:

>From bdc26201bb83df3786722a63c3caf387914f8539 Mon Sep 17 00:00:00 2001
From: Juan Quintela <quintela@redhat.com>
Date: Tue, 15 Dec 2009 21:53:26 +0100
Subject: [PATCH] user_only: compile everything with -fpie


Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 Makefile.user |    1 +
 configure     |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Makefile.user b/Makefile.user
index 907e74b..e4b5def 100644
--- a/Makefile.user
+++ b/Makefile.user
@@ -2,6 +2,7 @@

 include ../config-host.mak
 include $(SRC_PATH)/rules.mak
+include config.mak

 .PHONY: all

diff --git a/configure b/configure
index cf1db86..d815c7a 100755
--- a/configure
+++ b/configure
@@ -2652,3 +2652,6 @@ d=libuser
 mkdir -p $d
 rm -f $d/Makefile
 ln -s $source_path/Makefile.user $d/Makefile
+if test "$static" = "no" -a "$user_pie" = "yes" ; then
+  echo "QEMU_CFLAGS+=-fpie" > $d/config.mak
+fi
-- 
1.6.5.2

  reply	other threads:[~2009-12-15 20:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15  1:10 [Qemu-devel] [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie Kirill A. Shutemov
2009-12-15 19:48 ` [Qemu-devel] " Kirill A. Shutemov
2009-12-15 20:55   ` Juan Quintela [this message]
2009-12-16  8:45     ` Kirill A. Shutemov
2009-12-16  9:15       ` Paolo Bonzini
2009-12-16  9:25         ` Kirill A. Shutemov
2009-12-16 10:06           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m36388neii.fsf@neno.neno \
    --to=quintela@trasno.org \
    --cc=blauwirbel@gmail.com \
    --cc=kirill@shutemov.name \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.