From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFnKi-0000Se-JA
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:25:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFnKd-0000Q8-RD
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:25:19 -0500
Received: from [199.232.76.173] (port=42732 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFnKd-0000Q0-Cj
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:25:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44167)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1NFnKc-0001CV-F1
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:25:15 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4B164C21.3040406@siemens.com> (Jan Kiszka's message of "Wed, 02
	Dec 2009 12:14:41 +0100")
References: <4B15A8FA.5080804@web.de> <m3eindn11u.fsf@neno.neno>
	<4B164C21.3040406@siemens.com>
Date: Wed, 02 Dec 2009 12:24:27 +0100
Message-ID: <m3638phb4k.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH] vmstate: Avoid seeking
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Liran Schour <LIRANS@il.ibm.com>, Pierre Riteau <Pierre.Riteau@irisa.fr>

Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Juan Quintela wrote:
>> Jan Kiszka <jan.kiszka@web.de> wrote:
>>> Seeking on vmstate save/load does not work if the underlying file is a
>>> stream. We could try to make all QEMUFile* forward-seek-aware, but first
>>> attempts in this direction indicated that it's saner to convert the few
>>> qemu_fseek-on-vmstates users to plain reads/writes.
>>>
>>> This fixes various subtle vmstate corruptions where unused fields were
>>> involved.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> 
>> Something changed lately.  This used to work, and I also waste^spend
>> yesterday trying to understand why it was failing to me.
>
> I'm quite sure it never really worked. Maybe the bug was just papered over.
>
>> 
>> I am splitting the patch in virtio-net and savevm parts.  (In my tree
>> virtio-net don't use fseek anymore).
>
> OK, then I will drop this patch from my queue. BTW, where is your tree
> hosted?

http://repo.or.cz/w/qemu/quintela.git/shortlog/refs/heads/vmstate/virtio

This one has not still in upstream:
- the audio changes that I have just posted
- vmstate cleanups (yours and more)
- msix/virtio port to vmstate

I am splitting vmstate/cleanups at this moment to send the two series
upstream.  I am in the point where everything compiles and run,
i.e. only need to reorder patches.

Later, Juan.

>> 
>> Thanks for finding the bug.
>> 
>> Later, Juan.
>
> Jan