All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [PATCH] Terminate i386 local APIC DMI exception table
Date: Mon, 27 Sep 2004 13:48:49 +0200	[thread overview]
Message-ID: <m36560exum.fsf@averell.firstfloor.org> (raw)


[sending directly to Linus because Andrew said he is away] 

The i386 local APIC DMI exception table was not 0 terminated. The dmi
parser would walk into random .data space. Found during code review,
not known to cause problems, but should be still fixed.  I checked all
other DMI tables and they seemed to be ok.

Signed-off-by: Andi Kleen <ak@muc.de>

diff -u linux/arch/i386/kernel/apic.c-o linux/arch/i386/kernel/apic.c
--- linux/arch/i386/kernel/apic.c-o	2004-09-27 12:36:35.000000000 +0200
+++ linux/arch/i386/kernel/apic.c	2004-09-27 13:44:49.000000000 +0200
@@ -1233,7 +1233,8 @@
 static struct dmi_system_id __initdata apic_dmi_table[] = {
 	{ need_local_apic, "Intel C440GX+", {
 	  DMI_MATCH(DMI_BOARD_VENDOR,"Intel"),
-	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } }
+	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } },
+	{},
 };
 
 /*




                 reply	other threads:[~2004-09-27 11:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m36560exum.fsf@averell.firstfloor.org \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.