All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: Frediano Ziglio <freddyz77@tin.it>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>
Subject: Re: Packet writing problems
Date: 16 Aug 2004 21:09:19 +0200	[thread overview]
Message-ID: <m3657iq4rk.fsf@telia.com> (raw)
In-Reply-To: <m3acwuq5nc.fsf@telia.com>

Peter Osterlund <petero2@telia.com> writes:

> Frediano Ziglio <freddyz77@tin.it> writes:
> 
> > I'm trying to do packet writing with my new DVD writer.
> > 
> > # cat /proc/ide/hdc/model
> > PIONEER DVD-RW DVR-107D
> > 
> > dma enabled.
> > After some tests with 2.4 I decided to switch to 2.6.
> > I used Fedora Core 2 with a vanilla kernel 2.6.8.1 + patch from
> > http://w1.894.telia.com/~u89404340/patches/packet/2.6/, udftools with
> > Petero patch (http://w1.894.telia.com/~u89404340/patches/packet/, same
> > site and author).
> > 
> > However I get a lot of problems mount/unmounting devices...
> > 
> > DVD+RW
> > mkudffs /dev/hdc does not works... doing a strace opening /dev/hdc for
> > read/write open returns EROFS (or similar). I tried with blockdev
> > --setrw but still same errors...
> 
> I see two problems. The first problem is that the Mt Rainier detection
> can succeed when it shouldn't, because it forgets to check that the
> "GET CONFIGURATION" command returns the MRW feature number.

The second problem is in the dvdrw-support patch in the -mm kernel.
(This patch is also included in the patch you are using.)

The problem is that some drives fail the "GET CONFIGURATION" command
when asked to only return 8 bytes. This happens for example on my
drive, which is identified as:

        hdc: HL-DT-ST DVD+RW GCA-4040N, ATAPI CD/DVD-ROM drive

Since the cdrom_mmc3_profile() function already allocates 32 bytes for
the reply buffer, this patch is enough to make the command succeed on
my drive.

Signed-off-by: Peter Osterlund <petero2@telia.com>

---

 linux-petero/drivers/cdrom/cdrom.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/cdrom/cdrom.c~dvd+rw-get-configuration-fix drivers/cdrom/cdrom.c
--- linux/drivers/cdrom/cdrom.c~dvd+rw-get-configuration-fix	2004-08-16 20:54:49.710353928 +0200
+++ linux-petero/drivers/cdrom/cdrom.c	2004-08-16 20:55:41.514478504 +0200
@@ -834,7 +834,7 @@ static void cdrom_mmc3_profile(struct cd
 	cgc.cmd[0] = GPCMD_GET_CONFIGURATION;
 	cgc.cmd[1] = 0;
 	cgc.cmd[2] = cgc.cmd[3] = 0;		/* Starting Feature Number */
-	cgc.cmd[7] = 0; cgc.cmd [8] = 8;	/* Allocation Length */
+	cgc.cmd[8] = sizeof(buffer);		/* Allocation Length */
 	cgc.quiet = 1;
 
 	if ((ret = cdi->ops->generic_packet(cdi, &cgc))) {
_

-- 
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340

  reply	other threads:[~2004-08-16 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-16 15:16 Packet writing problems Frediano Ziglio
2004-08-16 18:50 ` Peter Osterlund
2004-08-16 19:09   ` Peter Osterlund [this message]
2004-08-16 19:51     ` Frediano Ziglio
2004-08-16 19:55     ` Frediano Ziglio
2004-08-17 19:59       ` Peter Osterlund
2004-08-17 20:24         ` Peter Osterlund
2004-08-17 23:31         ` Julien Oster
2004-08-17 23:36           ` Peter Osterlund
2004-08-18  8:25             ` Julien Oster
2004-08-18  8:38               ` Julien Oster
2004-08-18  8:48                 ` Julien Oster
     [not found] <20040818125719.GA6021@linux-ari.internal>
2004-08-18 17:08 ` Julien Oster
2004-08-19  6:56   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3657iq4rk.fsf@telia.com \
    --to=petero2@telia.com \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=freddyz77@tin.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.