From: Jes Sorensen <jes@wildopensource.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Jeff Garzik <garzik@pobox.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixup warning for acenic
Date: 20 Mar 2003 10:47:49 -0500 [thread overview]
Message-ID: <m365qenioq.fsf@trained-monkey.org> (raw)
In-Reply-To: "Martin J. Bligh"'s message of "Wed, 19 Mar 2003 23:50:29 -0800"
>>>>> "Martin" == Martin J Bligh <mbligh@aracnet.com> writes:
Martin> OK, it's war on warnings hour. Get this from acenic,
Martin> drivers/net/acenic.c:135: warning: `acenic_pci_tbl' defined
Martin> but not used
Martin> And indeed it doesn't *seem* to be used (though I'm less than
Martin> confident about that) ... can we just rip it out? Or should
Martin> this be wrapped in #ifdef MODULE or something (I'm compiling
Martin> it in)?
Hi Martin,
The table isn't used at the moment, however at some point it should
be. I have been reluctant to change the driver over to the new hotplug
scheme since in the past there has been a significant number of AceNIC
users running on older kernels which do not have the hotplug
infrastructure (2.4.9 etc). On the other hand I don't remember hearing
from a single person who wanted to use AceNIC in a hotplug
environment.
Anyway most people seems to be at 2.4.18 or later these days so maybe
it is time to retire the old code. I will try to find time to take a
look at it (or if someone beats me to it and sends me a patch ... ;-)
Cheers,
Jes
PS: There is an email address listed in the driver, please CC patches
to it.
next prev parent reply other threads:[~2003-03-20 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 7:50 [PATCH] Fixup warning for acenic Martin J. Bligh
2003-03-20 15:47 ` Jes Sorensen [this message]
2003-03-20 16:04 ` Christoph Hellwig
2003-03-20 16:11 ` Martin J. Bligh
2003-03-20 19:20 ` Greg KH
2003-03-20 19:13 ` Martin J. Bligh
2003-03-20 19:28 ` Jeff Garzik
2003-03-20 19:30 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2003-03-20 15:17 Matthew Wilcox
2003-03-20 15:50 ` Martin J. Bligh
2003-03-20 15:59 ` Matthew Wilcox
2003-03-20 16:10 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m365qenioq.fsf@trained-monkey.org \
--to=jes@wildopensource.com \
--cc=garzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.