From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Blin Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Date: Thu, 04 Feb 2016 00:41:39 +0100 Message-ID: References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1454511759-24827-3-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org> (Lubomir Rintel's message of "Wed, 3 Feb 2016 16:02:39 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-rpi-kernel" Errors-To: linux-rpi-kernel-bounces+glkr-linux-rpi-kernel=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Lubomir Rintel Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Chen , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Lubomir Rintel writes: > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > index ef54050..32bbd2a 100644 > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts Hi, Shouldn't this be common to all RPi1 B and RPi2 models, instead of being specific to just RPi B+? > +&usb { > + usb1@01 { > + compatible = "usb1d6b,0002"; > + reg = <01>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet: usbether@01 { > + compatible = "usb0424,9514"; > + reg = <01>; > + }; > + }; > +}; For reference, on RPi2: Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Thanks -- Olivier Blin - blino From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933763AbcBCXtx (ORCPT ); Wed, 3 Feb 2016 18:49:53 -0500 Received: from nan92-5-82-235-5-110.fbx.proxad.net ([82.235.5.110]:53984 "EHLO euphor.blino.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933711AbcBCXtv (ORCPT ); Wed, 3 Feb 2016 18:49:51 -0500 X-Greylist: delayed 488 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Feb 2016 18:49:50 EST From: Olivier Blin To: Lubomir Rintel Cc: linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Peter Chen Subject: Re: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> Date: Thu, 04 Feb 2016 00:41:39 +0100 In-Reply-To: <1454511759-24827-3-git-send-email-lkundrak@v3.sk> (Lubomir Rintel's message of "Wed, 3 Feb 2016 16:02:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lubomir Rintel writes: > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > index ef54050..32bbd2a 100644 > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts Hi, Shouldn't this be common to all RPi1 B and RPi2 models, instead of being specific to just RPi B+? > +&usb { > + usb1@01 { > + compatible = "usb1d6b,0002"; > + reg = <01>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet: usbether@01 { > + compatible = "usb0424,9514"; > + reg = <01>; > + }; > + }; > +}; For reference, on RPi2: Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Thanks -- Olivier Blin - blino