All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: David Ripton <dripton@ripton.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff and apply: fix singular/plural grammar nit.
Date: Sun, 27 Nov 2011 06:47:21 -0800 (PST)	[thread overview]
Message-ID: <m37h2lmxk9.fsf@localhost.localdomain> (raw)
In-Reply-To: <4ED23EB5.1030208@ripton.net>

David Ripton <dripton@ripton.net> writes:

> Remove the trailing 's' from "files", "insertions", and "deletions"
> when there is only one of the item.
> 
> Signed-off-by: David Ripton <dripton@ripton.net>
> ---
[...]
> -       printf(" %d files changed, %d insertions(+), %d
> deletions(-)\n", files, adds, dels);

Whitespace damaged.  Please turn off word wrapping (limiting line
width) when sending patches.

> +       printf(" %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
> +              files, (files == 1 ? "" : "s"),
> +              adds, (adds == 1 ? "" : "s"),
> +              dels, (dels == 1 ? "" : "s"));
>   }

First, I think this is an API / plumbing and should not be changed.
But I might be mistaken about that.

Second, it is a perfect example ho to *not* handle plural form in the
presence of internationalization (i18n) efforts.  See e.g.

  http://www.gnu.org/s/hello/manual/gettext/Plural-forms.html

-- 
Jakub Narębski

  reply	other threads:[~2011-11-27 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27 13:44 [PATCH] diff and apply: fix singular/plural grammar nit David Ripton
2011-11-27 14:47 ` Jakub Narebski [this message]
2011-11-27 14:50   ` Carlos Martín Nieto
2011-11-27 15:41     ` Frans Klaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37h2lmxk9.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=dripton@ripton.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.