All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Philip Rakity <prakity@marvell.com>
Cc: Barry Song <21cnbao@gmail.com>,
	Andrei Warkentin <andreiw@motorola.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"bin.shi@csr.com" <bin.shi@csr.com>,
	"Binghua.Duan@csr.com" <Binghua.Duan@csr.com>
Subject: Re: [PATCH] sdhci: add quirk to support shared bus controller
Date: Mon, 25 Apr 2011 17:43:36 -0400	[thread overview]
Message-ID: <m37haiuhvb.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <214C533D-E999-4FF2-AA99-F81526DBA529@marvell.com> (Philip Rakity's message of "Mon, 25 Apr 2011 11:18:06 -0700")

Hi,

On Mon, Apr 25 2011, Philip Rakity wrote:
> A quirk does not seem to the right way to go since there is now 2 points of failure
>
> a) The quirk can be defined and host->ops->get_shared_pins may not be.
>
> how about
>
> 	if (host->ops->get_shared_pins)
> 		host->ops->get_shared_pins(host)

Yep, I agree with Philip -- even if you use a quirk, you should test a
function pointer before calling it.  I also agree that you don't need
a quirk here because this isn't a modification to SDHCI spec behavior,
it's just a hook into platform code.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2011-04-25 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21  8:51 [PATCH] sdhci: add quirk to support shared bus controller Barry Song
2011-04-21  9:05 ` Andrei Warkentin
2011-04-25  1:27   ` Barry Song
2011-04-25 15:49     ` Barry Song
2011-04-25 18:18       ` Philip Rakity
2011-04-25 21:43         ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37haiuhvb.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=21cnbao@gmail.com \
    --cc=Binghua.Duan@csr.com \
    --cc=andreiw@motorola.com \
    --cc=bin.shi@csr.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.