From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path() Date: Wed, 16 Jun 2010 15:02:08 +0200 Message-ID: References: <20100614054923.879.33717.stgit@localhost.localdomain> <1276519930.12015.104.camel@x201> <201006141409.08653.paul@codesourcery.com> <4C17492A.4050207@siemens.com> <4C176B22.30201@siemens.com> <4C17976F.3080601@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "chrisw\@redhat.com" , "kraxel\@redhat.com" , "kvm\@vger.kernel.org" , "qemu-devel\@nongnu.org" , Alex Williamson , "avi\@redhat.com" , Paul Brook To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069Ab0FPNCV (ORCPT ); Wed, 16 Jun 2010 09:02:21 -0400 In-Reply-To: <4C17976F.3080601@siemens.com> (Jan Kiszka's message of "Tue, 15 Jun 2010 17:08:31 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: [...] >>> The format I will propose is "global-ID|/absolute/path", no more >>> /path/global-ID as this comes with the risk of ambiguity (ID may shadow >>> bus-local name of a device). >> >> Doesn't this break existing usage? > > Please name one. It could only be weird corner cases like "device_add > driver,bus=bus1/ID/bus2" or "bus=ID/bus". But given that we always > allowed to address "bus2" directly (and this is something I cannot and > will not change), does this really matter? Maybe allowing paths to start > with an ID is something worth considering, will think about this again. I checked with Dan: libvirt doesn't care. So I don't either. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47707 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOsG4-0004ri-C6 for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:02:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOsG3-0007Rb-1h for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:02:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33999) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOsG2-0007RQ-Nk for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:02:19 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path() References: <20100614054923.879.33717.stgit@localhost.localdomain> <1276519930.12015.104.camel@x201> <201006141409.08653.paul@codesourcery.com> <4C17492A.4050207@siemens.com> <4C176B22.30201@siemens.com> <4C17976F.3080601@siemens.com> Date: Wed, 16 Jun 2010 15:02:08 +0200 In-Reply-To: <4C17976F.3080601@siemens.com> (Jan Kiszka's message of "Tue, 15 Jun 2010 17:08:31 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "chrisw@redhat.com" , "kvm@vger.kernel.org" , Paul Brook , "qemu-devel@nongnu.org" , Alex Williamson , "avi@redhat.com" , "kraxel@redhat.com" Jan Kiszka writes: > Markus Armbruster wrote: >> Jan Kiszka writes: [...] >>> The format I will propose is "global-ID|/absolute/path", no more >>> /path/global-ID as this comes with the risk of ambiguity (ID may shadow >>> bus-local name of a device). >> >> Doesn't this break existing usage? > > Please name one. It could only be weird corner cases like "device_add > driver,bus=bus1/ID/bus2" or "bus=ID/bus". But given that we always > allowed to address "bus2" directly (and this is something I cannot and > will not change), does this really matter? Maybe allowing paths to start > with an ID is something worth considering, will think about this again. I checked with Dan: libvirt doesn't care. So I don't either. [...]