From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIeYm-0000sS-RV
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 03:39:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIeYi-0000qL-9O
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 03:39:40 -0500
Received: from [199.232.76.173] (port=42593 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIeYi-0000qG-57
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 03:39:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16114)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NIeYh-0008Tq-BI
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 03:39:35 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [FOR 0.12 PATCH v4 01/22] default devices: qdev
	integration.
References: <1260274314-2906-1-git-send-email-kraxel@redhat.com>
Date: Thu, 10 Dec 2009 09:39:33 +0100
In-Reply-To: <1260274314-2906-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Tue, 8 Dec 2009 13:11:32 +0100")
Message-ID: <m37hsvi5oa.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, agraf@suse.de

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
> Qemu creates a bunch of default devices (serial, parallel, vga, ...) if
> the user didn't specify one on the command line.  Unfortunaly this
> doesn't work well with the qdev way of doing things because this logic
> is tied to the -serial, -parallel, ... command line switches.  Devices
> created via -device are ignored.  This patch set fixes this.  It also
> adds a command line switch to disable all default devices and does a few
> cleanups in the code touched anyway.
>
> New in v3: Rebased against latest master.  Two patches (qmp monitor +
> s390 console) came into the way.  Because the way how serial lines and
> the monitor are initialized changes quite heavily it looked alot cleaner
> to me just revert those patches, apply the v2 patches, then reimplement
> the two patches on top of that.
>
> New in v4:
>  * Rebased against latest master.
>  * Moved the included fixes from (yesterdays) staging to the head
>    of this series.
>  * Fixed segfault without -monitor switch.
>  * Killed noisy debug leftover.
>  * Replaced fprintf("fixme") with a real error message.
>  * Better commit messages for the monitor changes.
>  * Killed the #ifdef for s390 virtio console.
>
> Luiz + Alex, please have a closer look at this.
>
> http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/default.v4
>
> thanks,
>   Gerd

Series looks good to me, my nitpicking on some of its parts
notwithstanding.  Without it, chardev entries in configuration files are
broken, -device doesn't work for the first serial, parallel, NIC, and
-drive doesn't work for first CD-ROM, floppy or SD.  These are important
fixes, so please consider for 0.12.