From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] media: imx7-media-csi: get rid of unused var
Date: Wed, 20 Feb 2019 11:23:20 +0000 [thread overview]
Message-ID: <m38syau2jb.fsf@gmail.com> (raw)
In-Reply-To: <91937229883824924f1a06ded49dfded4ca96d43.1550582690.git.mchehab+samsung@kernel.org>
Oi Mauro,
On Tue 19 Feb 2019 at 13:24, Mauro Carvalho Chehab wrote:
> drivers/staging/media/imx/imx7-media-csi.c: In function
> 'imx7_csi_enum_mbus_code':
> drivers/staging/media/imx/imx7-media-csi.c:926:33:
> warning: variable 'in_cc' set but not used
> [-Wunused-but-set-variable]
> const struct imx_media_pixfmt *in_cc;
> ^~~~~
>
> Signed-off-by: Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org>
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
---
Cheers,
Rui
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c
> b/drivers/staging/media/imx/imx7-media-csi.c
> index 0b1788d79ce9..3fba7c27c0ec 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -923,7 +923,6 @@ static int imx7_csi_enum_mbus_code(struct
> v4l2_subdev *sd,
> struct
> v4l2_subdev_mbus_code_enum *code)
> {
> struct imx7_csi *csi = v4l2_get_subdevdata(sd);
> - const struct imx_media_pixfmt *in_cc;
> struct v4l2_mbus_framefmt *in_fmt;
> int ret = 0;
>
> @@ -931,8 +930,6 @@ static int imx7_csi_enum_mbus_code(struct
> v4l2_subdev *sd,
>
> in_fmt = imx7_csi_get_format(csi, cfg, IMX7_CSI_PAD_SINK,
> code->which);
>
> - in_cc = imx_media_find_mbus_format(in_fmt->code,
> CS_SEL_ANY, true);
> -
> switch (code->pad) {
> case IMX7_CSI_PAD_SINK:
> ret = imx_media_enum_mbus_format(&code->code,
> code->index,
next prev parent reply other threads:[~2019-02-20 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 13:24 [PATCH 1/2] media: imx7-media-csi: don't store a floating pointer Mauro Carvalho Chehab
2019-02-19 13:24 ` [PATCH 2/2] media: imx7-media-csi: get rid of unused var Mauro Carvalho Chehab
2019-02-20 11:23 ` Rui Miguel Silva [this message]
2019-02-20 11:21 ` [PATCH 1/2] media: imx7-media-csi: don't store a floating pointer Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38syau2jb.fsf@gmail.com \
--to=rmfrfs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.