All of lore.kernel.org
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] perf-probe: make "perf-probe -L <function>" display the absolute path and absolute line number
Date: Thu, 13 Jan 2011 11:20:24 +0100	[thread overview]
Message-ID: <m38vyp85qv.fsf@gmail.com> (raw)

From: Franck Bui-Huu <fbuihuu@gmail.com>

It should be more usefull to get the full location of the function
(absolute line number + full path) instead of repeating the name of
the function and the start line number given by the command line.

So we had before:

   $ perf probe -L schedule | head -n3
   <schedule:0>
         0  asmlinkage void __sched schedule(void)
         1  {

and now we get:

   $ perf probe -L schedule | head -n3
   </usr/src/debug/kernel-2.6.35.fc14/linux-2.6.35.x86_64/kernel/sched.c:3813>
         0  asmlinkage void __sched schedule(void)
         1  {

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
 tools/perf/util/probe-event.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index fcbb543..bd09b87 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -382,11 +382,7 @@ int show_line_range(struct line_range *lr, const char *module)
 
 	setup_pager();
 
-	if (lr->function)
-		fprintf(stdout, "<%s:%d>\n", lr->function,
-			lr->start - lr->offset);
-	else
-		fprintf(stdout, "<%s:%d>\n", lr->path, lr->start);
+	fprintf(stdout, "<%s:%d>\n", lr->path, lr->start);
 
 	fp = fopen(lr->path, "r");
 	if (fp == NULL) {
-- 
1.7.3.2

             reply	other threads:[~2011-01-13 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13 10:20 Franck Bui-Huu [this message]
2011-01-13 11:03 ` [PATCH] perf-probe: make "perf-probe -L <function>" display the absolute path and absolute line number Masami Hiramatsu
2011-01-13 19:42   ` Franck Bui-Huu
2011-01-14  3:22     ` Masami Hiramatsu
2011-01-14  9:03       ` Franck Bui-Huu
2011-01-14 10:08         ` Masami Hiramatsu
2011-01-14 10:33         ` Masami Hiramatsu
2011-01-14 19:53           ` Franck Bui-Huu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38vyp85qv.fsf@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.