From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string
Date: Wed, 16 Jun 2010 10:36:08 +0200
Message-ID: <m38w6f4bnr.fsf@blackfin.pond.sub.org>
References: <20100614054923.879.33717.stgit@localhost.localdomain>
	<4C15D413.6020803@redhat.com> <1276545389.12015.499.camel@x201>
	<m3vd9k4qya.fsf@blackfin.pond.sub.org>
	<1276624893.12015.715.camel@x201>
	<m3eig74bqh.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: chrisw@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org, paul@codesourcery.com,
	avi@redhat.com
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:20445 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752378Ab0FPIgS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 16 Jun 2010 04:36:18 -0400
In-Reply-To: <m3eig74bqh.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Wed, 16 Jun 2010 10:34:30 +0200")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Markus Armbruster <armbru@redhat.com> writes:

> Alex Williamson <alex.williamson@redhat.com> writes:
>
>> On Tue, 2010-06-15 at 10:53 +0200, Markus Armbruster wrote:
>>> Alex Williamson <alex.williamson@redhat.com> writes:
[...]
>>> > virtio-serial doesn't seem to make a DeviceState per port, so I think it
>>> > can be skipped.
>>> 
>>> Really?
>>> 
>>> Anyway, its port number should do as bus address.
>>
>> Maybe I'm not specifying it correctly.  I see a max_nr_ports property,
>> but I don't see that each port is a separate qdev.
>
> I see property "nr" in virtconsole_info and virtserialport_info.  I
> can't see any other virtio-serial devices.

Same issue as with ide-drive's unit: should be a bus property.

[...]