From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKv8L-0001OE-M8
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:45:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKv8G-0001KM-Ud
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:45:45 -0500
Received: from [199.232.76.173] (port=60510 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKv8G-0001KI-LZ
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:45:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45599)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NKv8F-0003LJ-Cr
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 09:45:40 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBGEjYlB024705
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 16 Dec 2009 09:45:34 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.
References: <1260889756-26864-1-git-send-email-kraxel@redhat.com>
	<m3pr6f9qww.fsf@crossbow.pond.sub.org> <4B28E0C7.3010605@redhat.com>
Date: Wed, 16 Dec 2009 15:45:32 +0100
In-Reply-To: <4B28E0C7.3010605@redhat.com> (Gerd Hoffmann's message of "Wed,
	16 Dec 2009 14:29:43 +0100")
Message-ID: <m38wd3565v.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> On 12/16/09 11:03, Markus Armbruster wrote:
>> This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but problems
>> remain:
>>
>> * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd
>>
>>            dev: isa-fdc, id ""
>>              dev-prop: driveA = floppy0
>>              dev-prop: driveB =<null>
>>              isa irq 6
>
> Patch is on the list.

Subject: [Qemu-devel] [FOR 0.12 PATCH 1/2] defaults: split default_drive
Subject: [Qemu-devel] [FOR 0.12 PATCH 2/2] defaults: update device_list[]

Works fine for me, just one oddity: setting any of the fdc's two drives
kills the default, i.e. setting driveB makes driveA empty.

>> * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd,driveB=fd
>
> Oh, -global works like -set, i.e. you can't set multiple properties in
> one go.  Should be '-global isa-fdc.driveA=fd -global
> isa-fdc.driveB=fd'.
>
> The error reporting is *ahem*, well, not perfect.  Patch is on the list.

Subject: [Qemu-devel] [FOR 0.12 PATCH] qdev: improve property error reporting.

Works fine now.