All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederman@lnxi.com (Eric W. Biederman)
To: Andy Hawkins <a.hawkins@cabletime.com>,
	 D.A.Fedorov@inp.nsk.su, linux-mtd@lists.infradead.org,
	 Thayne Harbaugh <tharbaugh@lnxi.com>
Subject: Re: Problem writing to NOR flash
Date: 12 Aug 2004 00:59:37 -0600	[thread overview]
Message-ID: <m38yck6duu.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <m37jsdnp6w.fsf@maxwell.lnxi.com>

ebiederman@lnxi.com (Eric W. Biederman) writes:

> Andy Hawkins <a.hawkins@cabletime.com> writes:
> 

> > If so,
> > what is the *correct* way for this code to determine whether or not they
> > are needed (this code is in a 'generic' file, so I'm surprised that
> > there's chip specific information in there).
> 
> 
> I have the first chunk done but I'm not ready to check it
> in until I have a chance to test it.  And I am swamped right now..

Well the changes wound up being a little more extensive than
I described them.  But the code in cfi_cmdset_0001 and cfi_cmdset_0002 should
now be free of incorrect assumptions about what a flash chip can do.

As for the correct way to do this it probably still needs a little more
code review but there are fixup functions that are called when command sets
are initialized that allow for weird cases to be special cased.

Eric

  reply	other threads:[~2004-08-12  6:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 13:32 Problem writing to NOR flash Andy Hawkins
2004-07-26 14:00 ` Dmitry A. Fedorov
2004-07-26 14:11   ` Andy Hawkins
2004-07-26 14:35     ` Dmitry A. Fedorov
2004-07-26 14:49       ` Andy Hawkins
2004-07-26 15:00         ` Dmitry A. Fedorov
2004-07-26 15:39           ` Andy Hawkins
2004-07-26 16:07             ` Andy Hawkins
2004-08-05 23:24               ` Eric W. Biederman
2004-08-12  6:59                 ` Eric W. Biederman [this message]
2004-07-29 19:41 ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2004-07-19 16:06 Andy Hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38yck6duu.fsf@maxwell.lnxi.com \
    --to=ebiederman@lnxi.com \
    --cc=D.A.Fedorov@inp.nsk.su \
    --cc=a.hawkins@cabletime.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tharbaugh@lnxi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.