From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqhp1-0003jw-Ga for qemu-devel@nongnu.org; Fri, 27 Jan 2012 04:10:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqhot-0003vK-QK for qemu-devel@nongnu.org; Fri, 27 Jan 2012 04:10:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqhot-0003uk-Fl for qemu-devel@nongnu.org; Fri, 27 Jan 2012 04:10:07 -0500 From: Markus Armbruster References: <1327308641-14736-1-git-send-email-hpoussin@reactos.org> <1327308641-14736-8-git-send-email-hpoussin@reactos.org> Date: Fri, 27 Jan 2012 09:56:05 +0100 In-Reply-To: <1327308641-14736-8-git-send-email-hpoussin@reactos.org> (=?utf-8?Q?=22Herv=C3=A9?= Poussineau"'s message of "Mon, 23 Jan 2012 09:50:38 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Herv=C3=A9?= Poussineau Cc: Kevin Wolf , qemu-devel@nongnu.org Herv=C3=A9 Poussineau writes: > The programmed rate has to be the same as the required rate for the > floppy format ; if that's not the case, the transfer should abort. > > Revalidate floppy after migration, so media_rate field doesn't have > to be saved/restored. I'm not at all sure that's a good idea. The rate is guest state. It's value depends on the media. We guess the media to use for a particular image. Same thing as for the geometry (heads, tracks, sectors per track). We do migrate the geometry, see vmstate_fdrive. Why is it a good idea to treat rate differently? Doesn't your fd_revalidate() in fdc_post_load() clobber the migrated geometry?