From: Markus Armbruster <armbru@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.
Date: Mon, 25 Oct 2010 17:06:51 +0200 [thread overview]
Message-ID: <m3aam2tipg.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1287928933-11423-2-git-send-email-gleb@redhat.com> (Gleb Natapov's message of "Sun, 24 Oct 2010 16:02:12 +0200")
Gleb Natapov <gleb@redhat.com> writes:
> Prevent two devices from claiming the same io port.
Really?
Your new check for double-claim is in the new isa_init_ioport(), which
is for ISADevice only. Thus, only qdevified ISA devices can opt for
this protection, by calling isa_init_ioport(). It doesn't protect from
devices who don't or can't opt in, such as PCI devices.
Anyway, we already check for double-claim in
register_ioport_{read,write}(). The check has issues --- hw_error() is
wrong there for hot plug. But it's where the check should be, isn't it?
next prev parent reply other threads:[~2010-10-25 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 14:02 [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus Gleb Natapov
2010-10-24 14:02 ` [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev Gleb Natapov
2010-10-25 15:06 ` Markus Armbruster [this message]
2010-10-25 16:58 ` Gleb Natapov
2010-10-25 18:01 ` Markus Armbruster
2010-10-25 18:15 ` Gleb Natapov
2010-10-26 9:49 ` Markus Armbruster
2010-10-26 10:29 ` Gleb Natapov
2010-10-24 14:02 ` [Qemu-devel] [PATCH 2/2] Add get_dev_path callback to ISA bus " Gleb Natapov
2010-10-25 15:10 ` [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus Markus Armbruster
2010-10-25 17:00 ` Gleb Natapov
2010-10-25 17:53 ` Markus Armbruster
2010-10-25 18:06 ` Gleb Natapov
2010-10-26 9:57 ` Markus Armbruster
2010-10-26 10:38 ` Gleb Natapov
2010-10-26 11:04 ` Markus Armbruster
2010-10-26 11:13 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aam2tipg.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.