From: Jakub Narebski <jnareb@gmail.com>
To: Dun Peal <dunpealer@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: Efficiently detecting paths that differ from each other only in case
Date: Sat, 09 Oct 2010 01:47:12 -0700 (PDT) [thread overview]
Message-ID: <m3aamng3dt.fsf@localhost.localdomain> (raw)
In-Reply-To: <AANLkTi=YQOVYsK6Brq5pMiAdrH3Un7RgrWvYf_pymT=d@mail.gmail.com>
Dun Peal <dunpealer@gmail.com> writes:
> On Fri, Oct 8, 2010 at 3:06 PM, Jeff King <peff@peff.net> wrote:
> > Re-reading your original message, I have a few more thoughts.
> >
> > One is that you don't need to do this per-commit. You probably want to
> > do it per-updated-ref, each of which may be pushing many commits. And
> > then you either reject the new ref value or not.
>
> I think I do, actually, because let's say the developer pushes two
> commits, 1<-2. Suppose commit 1 violates the rule, but commit 2
> reverts the violation. One might think that we don't care, since the
> head will now be on 2, which is a correct state. But in fact we do,
> because this is Git, and anyone may branch of from 1 in the future,
> and voila we have a head in an incorrect state.
Sidenote: why not detect violation earlier, by having pre-commit hook
in each developer repository check for such violation? It is not as
time sensitive on the local side (when creating a commit, you have to
take some time to write commit message anyway).
See how example pre-commit hook check for "non-ascii" file names.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-10-09 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 6:13 Efficiently detecting paths that differ from each other only in case Dun Peal
2010-10-08 13:50 ` Jeff King
2010-10-08 19:44 ` Dun Peal
2010-10-08 19:51 ` Jeff King
2010-10-08 19:57 ` Dun Peal
2010-10-08 20:06 ` Jeff King
2010-10-08 22:57 ` Dun Peal
2010-10-09 8:47 ` Jakub Narebski [this message]
2010-10-09 22:00 ` Dun Peal
2010-10-09 22:31 ` Jakub Narebski
2010-10-11 3:07 ` Jeff King
2010-10-16 22:37 ` Dun Peal
2010-10-17 4:25 ` Jeff King
2010-10-08 19:56 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aamng3dt.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=dunpealer@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.