From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38342 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ORTca-0007tD-4T
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 13:20:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1ORTcX-0007Zm-4J
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 13:20:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7824)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1ORTcW-0007ZY-PM
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 13:20:17 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5NHKGvf003436
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 23 Jun 2010 13:20:16 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()
References: <1277228451-7741-1-git-send-email-lcapitulino@redhat.com>
	<1277228451-7741-13-git-send-email-lcapitulino@redhat.com>
	<m3lja5ydpx.fsf@blackfin.pond.sub.org>
	<20100623132904.79d8e424@redhat.com>
Date: Wed, 23 Jun 2010 19:20:14 +0200
In-Reply-To: <20100623132904.79d8e424@redhat.com> (Luiz Capitulino's message
	of "Wed, 23 Jun 2010 13:29:04 -0300")
Message-ID: <m3aaqlpsxd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Wed, 23 Jun 2010 17:23:54 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> writes:
[...]
>> > +            qerror_report(QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER, arg_name);
>> 
>> Identifier's a bit on the long side, isn't it?
>
> Yes, suggestions?

What about omitting INPUT_OBJECT or at least OBJECT?

EXTRA instead of UNEXPECTED?

We could have

QERR_QMP_EXTRA_MEMBER
QERR_QMP_MISSING_MEMBER         now: QERR_QMP_BAD_INPUT_OBJECT (I think)      
QERR_QMP_BAD_MEMBER             now: QERR_QMP_BAD_INPUT_OBJECT_MEMBER

[...]