From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32940 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OP1b8-0001F5-2h
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 19:00:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OP1b6-000177-F2
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 19:00:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52750)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OP1b6-00016w-5s
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 19:00:40 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4C194FA2.7050501@codemonkey.ws> (Anthony Liguori's message of
	"Wed, 16 Jun 2010 17:26:42 -0500")
References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com>
	<1276619430-15871-7-git-send-email-aliguori@us.ibm.com>
	<m3631jnmv7.fsf@trasno.mitica> <20100616162544.GS13996@redhat.com>
	<4C190760.9070605@codemonkey.ws> <m3typ2r5v7.fsf@trasno.mitica>
	<4C194FA2.7050501@codemonkey.ws>
Date: Thu, 17 Jun 2010 01:00:25 +0200
Message-ID: <m3aaqur3au.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [CFR 6/10] cont command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 06/16/2010 05:05 PM, Juan Quintela wrote:
>> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>>    
>>> On 06/16/2010 11:25 AM, Daniel P. Berrange wrote:
>>>      
>>>>        
>>>>> This is related to the commands, not QMP per se:
>>>>>
>>>>> Once that we are talking about "cont" command.  There are two cases that
>>>>> we need to think of:
>>>>>
>>>>> - incoming migration:
>>>>>
>>>>> If you start with -incoming foo, and then run "cont" on the monitor
>>>>> without having started the migration .... corruption is ensured.
>>>>>
>>>>>          
>>>> This is why '-incoming' command line arg should die, and be replaced
>>>> with a 'incoming' monitor command that would simply not allow 'cont'
>>>> to be run until it completed.
>>>>
>>>> For that matter, even with '-incoming' arg on command line we could
>>>> refuse to honour 'cont' until the incoming migration had been done.
>>>>
>>>>        
>>> If we had an incoming migration command, I think we'd have to think
>>> careful about it's semantics.  Is it reasonable to allow a machine
>>> that's otherwise running to do an incoming command?
>>>      
>> It is the same problem that loadvm.
>>
>> And no, loadvm several times don't work well either.
>>    
>
> It's supposed to.  If it doesn't, then there's a bug somewhere.

I haven't tried lately, but when I tried (months ago, 0.12.0 timeframe),
it didn't work correctly the 2nd/3rd time.  I ended to always loading
from a fresh image, much easier to get it right.

Later, Juan.