From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 04 Nov 2009 12:34:38 +0100 (CET) Received: from mx1.moondrake.net ([212.85.150.166]:37344 "EHLO mx1.mandriva.com" rhost-flags-OK-OK-OK-FAIL) by ftp.linux-mips.org with ESMTP id S1493074AbZKDLec (ORCPT ); Wed, 4 Nov 2009 12:34:32 +0100 Received: by mx1.mandriva.com (Postfix, from userid 501) id 1D807274004; Wed, 4 Nov 2009 12:34:31 +0100 (CET) Received: from office-abk.mandriva.com (unknown [195.7.104.248]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.mandriva.com (Postfix) with ESMTP id 094F0274003; Wed, 4 Nov 2009 12:34:30 +0100 (CET) Received: from anduin.mandriva.com (fw2.mandriva.com [192.168.2.3]) by office-abk.mandriva.com (Postfix) with ESMTP id A19F482919; Wed, 4 Nov 2009 12:45:57 +0100 (CET) Received: from anduin.mandriva.com (localhost [127.0.0.1]) by anduin.mandriva.com (Postfix) with ESMTP id 7601BFF855; Wed, 4 Nov 2009 12:34:44 +0100 (CET) From: Arnaud Patard To: wuzhangjin@gmail.com Cc: Ralf Baechle , linux-mips@linux-mips.org, LKML , huhb@lemote.com, yanh@lemote.com, Zhang Le , Thomas Gleixner , Nicholas Mc Guire , zhangfx@lemote.com, liujl@lemote.com Subject: Re: [PATCH -queue v0 5/6] [loongson] rtc: enable legacy RTC driver on fuloong2f References: <1257333527.8716.20.camel@falcon.domain.org> Organization: Mandriva Date: Wed, 04 Nov 2009 12:34:44 +0100 In-Reply-To: <1257333527.8716.20.camel@falcon.domain.org> (Wu Zhangjin's message of "Wed, 04 Nov 2009 19:18:47 +0800") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 24671 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: apatard@mandriva.com Precedence: bulk X-list: linux-mips Wu Zhangjin writes: > Hi, > > On Wed, 2009-11-04 at 11:40 +0100, Arnaud Patard wrote: >> Wu Zhangjin writes: >> >> Hi, >> >> > RTC_LIB is selected by MIPS by default, and therefore, the legacy RTC driver is >> > disabled. but unfortunately, RTC_LIB not works on fulong, so, enabling the legcy >> > RTC driver is needed, otherwise, the tools like hwclock will not work. >> > >> > because loongson family machines, including fuloong2e, fuloong2f and >> > yeeloong2f need to enable legacy RTC driver, so we use MACH_LOONGSON >> > here. >> >> There are loongson machines which are working fine with RTC_LIB (for >> instance the gdium which is using a m41t83 on i2c) so would be better to >> be more restrictive imho. > > In reality, fuloong2e, fuloong2f and yeeloong2f work fine with RTC_LIB, > but relative patches need to append to drivers/rtc/rtc-cmos.c and also > need a RTC platform device. If what I remembered is right, Gdium also > need corresponding patches to make it work with RTC_LIB. As I said, Gdium is using an i2c chip and the bus is made with the sm501 gpio. So except the patch for gpiolib support for ls2f, there's nothing special for RTC_LIB. It's just working out of the box (as long as you declare the platform devices but that's not what I call a problem). > > Herein, I just let the basic support for those machines work, and then, > the RTC_LIB support will be sent out later. > > and a small question: if legacy RTC driver works well on these machines, > why should we forbid people to use it? I think it's better to remove the > "select RTC_LIB" line for MIPS, and then, the people will be free to > choose what they want, and even for the users whose platform not support > RTC_LIB. Well, I though about this. If you go that way and remove the "select RTC_LIB", please check and enable it for all platforms which needs it or warn people about. Would be nice to avoid regression due to that. Arnaud