From: Andi Kleen <ak@muc.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: stat very inefficient
Date: Wed, 28 Jul 2004 12:16:40 +0200 [thread overview]
Message-ID: <m3acxkighj.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2mN94-3MP-9@gated-at.bofh.it> (David S. Miller's message of "Wed, 28 Jul 2004 05:20:06 +0200")
"David S. Miller" <davem@redhat.com> writes:
> 1) From inode to "struct kstat"
> 2) From "struct kstat" to "struct stat{,64}" on local kernel stack
> 3) From local kernel stack to userspace
[...]
> I was about to make sparc64 specific copies of all the stat
> system calls in order to optimize this properly. But that
> makes little sense, instead I think fs/stat.c should call
> upon arch-specific stat{,64} structure fillin routines that
> can do the magic, given a kstat struct.
I think wrappers are preferable to callbacks. Basically step (2)
should be eliminated.
Most architectures can use a generic wrapper for that, together
with a standard macro that clears all the padding in user space.
-Andi
next parent reply other threads:[~2004-07-28 10:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2mN94-3MP-9@gated-at.bofh.it>
2004-07-28 10:16 ` Andi Kleen [this message]
2004-07-28 15:38 ` stat very inefficient David S. Miller
[not found] <233602095@toto.iv>
2004-07-28 22:33 ` Peter Chubb
2004-07-28 22:45 ` David S. Miller
2004-07-29 0:08 ` Chris Wedgwood
2004-07-29 0:14 ` David S. Miller
2004-07-29 0:24 ` Chris Wedgwood
2004-07-29 0:29 ` viro
2004-07-29 7:26 ` Peter Chubb
2004-07-29 7:42 ` Andrew Morton
2004-07-29 8:49 ` Paul Jackson
2004-07-29 9:02 ` Andrew Morton
2004-07-29 9:17 ` Peter Chubb
2004-07-29 7:45 ` Ulrich Drepper
2004-07-29 11:42 ` Nigel Rantor
2004-07-29 1:07 ` Ulrich Drepper
2004-07-29 2:22 ` Paul Jackson
2004-07-29 4:10 ` Ulrich Drepper
2004-07-29 6:18 ` Paul Jackson
2004-07-28 3:13 David S. Miller
2004-07-28 18:07 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3acxkighj.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.