From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNo64-0000AN-Ca for qemu-devel@nongnu.org; Tue, 08 Nov 2011 11:00:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNo5z-0007RD-78 for qemu-devel@nongnu.org; Tue, 08 Nov 2011 11:00:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNo5y-0007R6-PP for qemu-devel@nongnu.org; Tue, 08 Nov 2011 11:00:19 -0500 From: Markus Armbruster References: <1320757056-16154-1-git-send-email-chenwj@iis.sinica.edu.tw> <20111108144337.GB51305@cs.nctu.edu.tw> <20111108151623.GA65548@cs.nctu.edu.tw> Date: Tue, 08 Nov 2011 17:00:01 +0100 In-Reply-To: <20111108151623.GA65548@cs.nctu.edu.tw> (=?utf-8?B?IumZsw==?= =?utf-8?B?6Z+L5Lu7Iidz?= message of "Tue, 8 Nov 2011 23:16:23 +0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?6Zmz6Z+L5Lu7?= Cc: qemu-devel@nongnu.org =E9=99=B3=E9=9F=8B=E4=BB=BB writes: > On Tue, Nov 08, 2011 at 04:07:12PM +0100, Markus Armbruster wrote: >> =E9=99=B3=E9=9F=8B=E4=BB=BB writes: >>=20 >> >> Please thread together your patches so that the parts appear as repli= es >> >> to the cover letter. git-send-email should do that by default. >> >>=20 >> >> Why? Disconnected parts can easily get separated in the list. When >> >> that happens, your reviewers need to hunt for parts. They may choose= to >> >> review something else instead. Can't blame them; reviewing is more >> >> productive than hunting for parts. >> > >> > Sorry about that. Should I re-sent this series? >>=20 >> Try that if you don't get reviews ;) Else just get it right with your >> next patch series. > > O.K.. Just want to make sure. What you said "thread together your > patches" has something to do with "sendemail.chainreplyto"? I found > I sent this series one by one, i.e., `git send-email 000#.patch`. > I think I should sent them as a whole, i.e., `git send-email *`. But > I am not sure "sendemail.chainreplyto" matters or not. Max already explaind chainreplyto. I agree with him that chainreplyto off is preferable. But what you're after is --thread / sendemail.thread. See man git-send-email for details. The default is --thread, which does the threading, provided you send all parts at once.