From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcY2l-0003ce-LO
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:21:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcY2j-0007V3-IR
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:21:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41360)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcY2i-0007Uy-Nz
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:21:37 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p617LZ5I028706
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 1 Jul 2011 03:21:36 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com>
	<1309458783-12661-4-git-send-email-lcapitulino@redhat.com>
Date: Fri, 01 Jul 2011 09:21:33 +0200
In-Reply-To: <1309458783-12661-4-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Thu, 30 Jun 2011 15:33:03 -0300")
Message-ID: <m3boxe79fm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS
	setting error message
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> The current media doesn't clearly say the error cause.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  blockdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 0a90ae8..2dbdd1b 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -311,7 +311,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
>  	        media = MEDIA_DISK;
>  	    } else if (!strcmp(buf, "cdrom")) {
>              if (cyls || secs || heads) {
> -                error_report("'%s' invalid physical CHS format", buf);
> +                error_report("CHS can't be set for CDROM media '%s'", buf);
>  	            return NULL;
>              }
>  	        media = MEDIA_CDROM;

It's an improvement.  I'd like "CHS can't be set with media=%s" even
better, because it's closer to the actual option string.  Matter of
taste.