From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55118 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWRBo-0004kv-9x
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OWRBm-0006d6-6R
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23498)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OWRBl-0006ck-TG
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 05:45:10 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1278419869-26126-1-git-send-email-armbru@redhat.com>
	<1278419869-26126-7-git-send-email-armbru@redhat.com>
	<20100707013700.GF3073@lst.de> <4C342F09.2060500@redhat.com>
Date: Wed, 07 Jul 2010 11:33:19 +0200
In-Reply-To: <4C342F09.2060500@redhat.com> (Kevin Wolf's message of "Wed, 07
	Jul 2010 09:38:49 +0200")
Message-ID: <m3bpajprfk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 6/8] scsi: Split qdev "scsi-disk" into
	"scsi-hd" and "scsi-cd"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: kraxel@redhat.com, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

Kevin Wolf <kwolf@redhat.com> writes:

> Am 07.07.2010 03:37, schrieb Christoph Hellwig:
>> On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote:
>>> Disk vs. CD needs to be in qdev, because it belongs to the drive's
>>> guest part.
>> 
>> Looks good, but the scsi-hd name feelds kinda awkward.  This is one
>> case we're I'm really wondering if the compatiblity is worth it or
>> if we should just keep using scsi-disk for the real disk.
>
> In any case the name should be consistent with ide-hd. And I'm not sure
> if it's really helpful to have ide-drive and ide-disk.

{ide,scsi}-{hd,cd} is the best consistent set of names I could find
within the backward compatibility straightjacket.

By the way, we could use a way to mark qdevs and properties deprecated.