From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Driver Core update for 2.6.4
Date: Tue, 16 Mar 2004 17:14:47 +0100 [thread overview]
Message-ID: <m3brmwojk8.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1AjwZ-65D-15@gated-at.bofh.it> (Andrew Morton's message of "Tue, 16 Mar 2004 11:00:25 +0100")
Andrew Morton <akpm@osdl.org> writes:
>
> eh? If there is any argument against this code it is that it is so simple
> that the thing which it abstracts is not worth abstracting. But given that
> it is so unwasteful, this seems unimportant.
The bloat argument was about the additional pointer in the dynamic
data structure (on a 64bit architecture it costs 12 bytes)
Better would be to pass the callback to kref_put(), but then it would
be even better to just test the return value (callbacks are obfuscation
and should be avoided when not needed)
-Andi
next parent reply other threads:[~2004-03-16 16:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1AajM-5vw-21@gated-at.bofh.it>
[not found] ` <1Abpq-6Av-1@gated-at.bofh.it>
[not found] ` <1Aj3K-5Fn-9@gated-at.bofh.it>
[not found] ` <1AjwZ-65D-15@gated-at.bofh.it>
2004-03-16 16:14 ` Andi Kleen [this message]
2004-03-16 19:40 ` [PATCH] Driver Core update for 2.6.4 Greg KH
2004-03-17 0:01 ` Andi Kleen
2004-03-19 9:17 ` Jamie Lokier
2004-03-19 11:52 ` Giuseppe Bilotta
2004-03-15 23:55 [BK PATCH] " Greg KH
2004-03-15 23:59 ` [PATCH] " Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-15 23:59 ` Greg KH
2004-03-16 7:04 ` Christoph Hellwig
2004-03-16 9:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3brmwojk8.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.