From: Jakub Narebski <jnareb@gmail.com>
To: Sylvain Rabot <sylvain@abstraction.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] gitweb: decorate a bit more remotes
Date: Mon, 20 Dec 2010 15:11:14 -0800 (PST) [thread overview]
Message-ID: <m3d3owkplq.fsf@localhost.localdomain> (raw)
In-Reply-To: <1292871681-4818-3-git-send-email-sylvain@abstraction.fr>
Sylvain Rabot <sylvain@abstraction.fr> writes:
> - $urls_table .= format_repo_url("URL", $fetch);
> + $urls_table .= format_repo_url("<span class=\"bold\">URL:</span>", $fetch);
[...]
> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index 79d7eeb..ce902f5 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -579,6 +579,10 @@ div.remote {
> display: inline-block;
> }
>
> +.bold {
> + font-weight: bold;
> +}
<span class="bold"> is not much different from <strong> or <b>;
I'd rather you use some semantic name for the class, describing
what content it contains rather than what style it uses.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-12-20 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 19:01 [PATCH 0/3 v2] minor gitweb modifications Sylvain Rabot
2010-12-20 19:01 ` [PATCH 1/3] gitweb: add extensions to highlight feature Sylvain Rabot
2010-12-20 19:01 ` [PATCH 2/3] gitweb: decorate a bit more remotes Sylvain Rabot
2010-12-20 20:02 ` Jonathan Nieder
2010-12-20 23:06 ` Jakub Narebski
2010-12-20 23:11 ` Jakub Narebski [this message]
2010-12-20 19:01 ` [PATCH 3/3] gitweb: remove test when closing file descriptor Sylvain Rabot
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 21:43 [PATCH 0/3] minor gitweb modifications Sylvain Rabot
2010-12-16 21:43 ` [PATCH 2/3] gitweb: decorate a bit more remotes Sylvain Rabot
2010-12-16 22:23 ` Jakub Narebski
2010-12-20 12:04 ` Drew Northup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3owkplq.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=sylvain@abstraction.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.