From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53731 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PTPFp-00009s-B6 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 20:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PTPFn-0004Pf-Tx for qemu-devel@nongnu.org; Thu, 16 Dec 2010 20:37:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PTPFn-0004P2-N4 for qemu-devel@nongnu.org; Thu, 16 Dec 2010 20:37:03 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBH1axV6025737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Dec 2010 20:36:59 -0500 From: Juan Quintela In-Reply-To: <20101216175516.6420.66081.stgit@s20.home> (Alex Williamson's message of "Thu, 16 Dec 2010 11:01:49 -0700") References: <20101216175516.6420.66081.stgit@s20.home> Date: Fri, 17 Dec 2010 07:05:59 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 0/2] Fix rtl8139 migration with hotplug Reply-To: quintela@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Alex Williamson wrote: > Ok, I think this might actually make everyone happy, but I've been > known to be wrong about that many times before. Juan challenged me > to find an rtl8139 migration scenario that fails when hotplug is > not involved (and not switch device creation order since that's a > usage bug). I couldn't come up with one. We had been arguing that > a subsection didn't make sense for the change to rtl8139 vmstate > because the needed function would be {return 1}. but what if we > could detect if the VM had done any other hotplugs and only include > the subsection in those cases. That's what this short series does. > > So, I hope Juan is happy because this preserves the migration ABI > for the majority of the use cases, and I hope Michael is happy > because it does so using a subsection. Thanks, > > Alex I am happy. Thanks a lot. Acked-by: Juan Quintela