From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39156 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9ClH-00022g-65
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 04:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1P9CXW-0005vO-9X
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 03:59:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1P9CXW-0005v6-2o
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 03:59:50 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9M7xmZG001718
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 03:59:48 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it
References: <1287674149-25418-1-git-send-email-Jes.Sorensen@redhat.com>
Date: Fri, 22 Oct 2010 09:59:45 +0200
In-Reply-To: <1287674149-25418-1-git-send-email-Jes.Sorensen@redhat.com> (Jes
	Sorensen's message of "Thu, 21 Oct 2010 17:15:45 +0200")
Message-ID: <m3d3r2ejym.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

Jes.Sorensen@redhat.com writes:

> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> This patch introduces cutils.c: strtosz() and gets rid of the
> multiple custom hacks for parsing byte sizes. In addition it adds
> supports for specifying human style sizes such as 1.5G. Last it
> eliminates the horrible abuse of a float to store the byte size for
> migrate_set_speed in the monitor.
>
> Note, this is tested on Linux and build tested for win32 using
> mingw32.
>
> v9: I worked through a couple of revisions directly with Markus and I
> think I got it right finally. 

I'd prefer to have strtosz() to match strtol() & friends and not
restrict suffixes.  But this code does what it claims to do, as far as I
can see, so:

ACK series